Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mut from Signer trait methods. #162

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Remove mut from Signer trait methods. #162

merged 2 commits into from
Oct 12, 2021

Conversation

partim
Copy link
Member

@partim partim commented Oct 11, 2021

This PR changes the repository::crypto::signer::Signer trait to not require &mut self for its methods. It also changes the OpenSSL-based example signer to use interior mutability via RwLock.

@partim partim requested review from timbru and ximon18 October 11, 2021 11:44
@partim partim removed the request for review from timbru October 12, 2021 16:25
@partim partim merged commit 49b3822 into main Oct 12, 2021
@partim partim deleted the async-signer branch October 12, 2021 16:25
@ximon18 ximon18 linked an issue Oct 12, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async mut-less Signer trait
2 participants