Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct RFC number #275

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Correct RFC number #275

merged 2 commits into from
Nov 28, 2023

Conversation

ghane
Copy link
Contributor

@ghane ghane commented Nov 17, 2023

  • Correct RFC number (81821 -> 8182)
  • Add links to IETF datatracker and Wikipedia for context

- Correct RFC number (81821 -> 8182)
- Add links to IETF datatracker and Wikipedia for context
@ghane
Copy link
Contributor Author

ghane commented Nov 17, 2023

@partim Please review.

@partim
Copy link
Member

partim commented Nov 17, 2023

Thank you for the PR! It looks good!

I know it is a bit silly, what with the changes only being documentation, but could you nonetheless perchance merge main into your branch so the CI goes green before merging?

@ghane
Copy link
Contributor Author

ghane commented Nov 17, 2023

Thank you for the PR! It looks good!

I know it is a bit silly, what with the changes only being documentation, but could you nonetheless perchance merge main into your branch so the CI goes green before merging?

Not silly at all, I have never understood git, and my work is based on cheatsheets other OSS contributers have given me.

I assume the conflicts were with the clippy commit.

Rebased (I think) on NLnetLabs:main , and pushed again.

Thank you, and to the NLnet/NLNog team, for all your wonderful projects

@partim
Copy link
Member

partim commented Nov 28, 2023

Thank you and apologies, I somehow forgot to click the buttons.

@partim partim merged commit 49c202c into NLnetLabs:main Nov 28, 2023
12 checks passed
@ghane ghane deleted the ghane-patch-1 branch November 29, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants