Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzzing for payload and fix all the issues found. #113

Merged
merged 5 commits into from May 10, 2024
Merged

Conversation

partim
Copy link
Member

@partim partim commented May 3, 2024

This PR adds fuzzing via cargo fuzz to the payload module and adds fixes for the issues that the fuzzer uncovered.

@partim partim marked this pull request as draft May 3, 2024 10:50
@partim partim requested a review from a team May 6, 2024 16:06
@partim partim marked this pull request as ready for review May 6, 2024 16:06
Copy link
Contributor

@DRiKE DRiKE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Not related to the diff per se, but it seems the first line of docstring for fn filter on payload::Set is incorrect and contradicts the remainder of that docstring and the actual working of that function. It currently says '(..) indicated elements removed', instead of '(..) retained'.

fuzz/fuzz_targets/fuzz_target_1.rs Outdated Show resolved Hide resolved
@partim partim merged commit 205089d into main May 10, 2024
9 checks passed
@partim partim deleted the fuzz-payload branch May 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants