Make log_ident_revert_to_default() a proper prototype. #197
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointed out by clang with -Wstrict-prototypes.
wcawijngaards
added a commit
that referenced
this pull request
Mar 20, 2020
- Merge PR #197 from fobser: Make log_ident_revert_to_default() a proper prototype.
|
Thanks! That is a good catch and improvement, merged and included in the repository. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Apr 13, 2020
* nlnet/master: - Changelog note for PR NLnetLabs#198: Declare lz_enter_rr_into_zone() static, it's only used in this file, by fobser. Changelog note for NLnetLabs#197. - Merge PR NLnetLabs#197 from fobser: Make log_ident_revert_to_default() a proper prototype. Declare lz_enter_rr_into_zone() static, it's only used in this file. Pointed out by clang with -Wmissing-prototypes Make log_ident_revert_to_default() a proper prototype. Pointed out by clang with -Wstrict-prototypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed out by clang with -Wstrict-prototypes.