Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log_ident_revert_to_default() a proper prototype. #197

Merged
merged 1 commit into from Mar 20, 2020

Conversation

fobser
Copy link
Contributor

@fobser fobser commented Mar 20, 2020

Pointed out by clang with -Wstrict-prototypes.

Pointed out by clang with -Wstrict-prototypes.
@wcawijngaards wcawijngaards merged commit c262e1f into NLnetLabs:master Mar 20, 2020
1 check was pending
wcawijngaards added a commit that referenced this pull request Mar 20, 2020
- Merge PR #197 from fobser: Make log_ident_revert_to_default() a
  proper prototype.
@wcawijngaards
Copy link
Member

wcawijngaards commented Mar 20, 2020

Thanks! That is a good catch and improvement, merged and included in the repository.

@fobser fobser deleted the proper_prototype branch Mar 20, 2020
jedisct1 added a commit to jedisct1/unbound that referenced this pull request Apr 13, 2020
* nlnet/master:
  - Changelog note for PR NLnetLabs#198: Declare lz_enter_rr_into_zone() static,   it's only used in this file, by fobser.
  Changelog note for NLnetLabs#197. - Merge PR NLnetLabs#197 from fobser: Make log_ident_revert_to_default() a   proper prototype.
  Declare lz_enter_rr_into_zone() static, it's only used in this file. Pointed out by clang with -Wmissing-prototypes
  Make log_ident_revert_to_default() a proper prototype. Pointed out by clang with -Wstrict-prototypes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants