Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS is broken? HAVE_FORK is undef #279

Closed
FGasper opened this issue Aug 3, 2020 · 1 comment
Closed

macOS is broken? HAVE_FORK is undef #279

FGasper opened this issue Aug 3, 2020 · 1 comment
Assignees
@gthess

Comments

@FGasper
Copy link
Contributor

FGasper commented Aug 3, 2020

20dbd63
^^ This commit appears to have added logic that breaks the following CI run:
https://travis-ci.org/github/FGasper/p5-DNS-Unbound/jobs/714547957

It appears that HAVE_FORK is being undef’d because this code:

#if defined(TARGET_OS_TV) || defined(TARGET_OS_WATCH)
#undef HAVE_FORK
#endif

… should check truthiness as well as defined-ness.
@FGasper FGasper mentioned this issue Aug 3, 2020
Merged
@FGasper
Copy link
Contributor Author

FGasper commented Aug 3, 2020

For context, those constants are defined thus on my machine:

        #define TARGET_OS_OSX               1
        #define TARGET_OS_IPHONE            0
        #define TARGET_OS_IOS               0
        #define TARGET_OS_WATCH             0
        
        #define TARGET_OS_TV                0

@gthess gthess self-assigned this Aug 4, 2020
@gthess gthess closed this as completed in ded7fda Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gthess gthess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FGasper @gthess