Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnstap logging not recovering after dnstap process restarts (regression in 1.11) #304

Closed
abulimov opened this issue Sep 9, 2020 · 1 comment

Comments

@abulimov
Copy link

abulimov commented Sep 9, 2020

With unbound 1.11 being first release that switched away from libfstrm (#164, #264), we observe number of regressions with dnstap logging over unix socket.

This one is pretty obvious and relatively easy to reproduce:

* unbound running with dnstap logging enabled over unix socket, under some measurable load (few thousands+ requests per minute)
* dnstap process consuming the logs is restarted.

with 1.9.6, dnstap can reconnect to socket and process samples continuously
with 1.11.0, dnstap can reconnect to socket but receives only 99 samples, all stamped with ~time dnstap process was restarted. Next restart gets another 99 samples, and so on.

Restarting the unbound while leaving dnstap process to run mitigates the problem, until the next time dnstap is restarted.
Unbound's performance seems unaffected.
Doesn't happen when unbound is idle/lightly used.
We observe this on all our Unbound instances with 1.11, never happened on 1.9.6 or earlier versions we used before.

@ralphdolmans
Copy link
Contributor

Thanks for reporting! This should be fixed by commit 00fe4b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants