Bidirectional frame streams support #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Close connection when receiving overly large frame
This was referenced Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dnstap-bidirectionaloption (default yes) to use the bidirectional frame streams mode for sending DNSTAP messages. See also issue #245.Tested to work with the golang dnstap client, and unbound-dnstap-socket.
Not (yet) listening for FINISH frames. Not sure we need that. As far as I can tell FINISH frames are only sent after receiving the STOP frame, which we only send out right before closing a connection. As there are no frames to be received by Unbound after the ACCEPT frame I think it is fine to close immediately after sending the STOP, without waiting for FINISH.