Don't call a function which hasn't been defined #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
added a commit
that referenced
this pull request
Jul 16, 2021
|
Merged, looks good. I also added more in depth fixes in the commit that puts ifdefs around windows api event calls, so they happen when on windows. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jul 27, 2021
* nlnet/master: (175 commits) - Fix for older parsers for function call in serve expired get cached. - Another fix from lint for ignored return value. - Fix from lint for ignored return value. - Insert header into testcode/readzone.c, it was missing. - Introduce 'http-user-agent:' and 'hide-http-user-agent:' options. Revert "- With hide-version unbound also omits the version from http headers." - With hide-version unbound also omits the version from http headers. - review fix to remove duplicate error printout. - Fix unbound-control local_data and local_datas to print detailed syntax errors. - Fix spelling in localzone.h comment. - Fix spelling in doc/unbound.doxygen comment. - Fix for NLnetLabs#510: in depth, use ifdefs for windows api event calls. Don't call a function which hasn't been defined - iana portlist update. - Fix clang-analysis warnings for testcode/readzone.c. - Fix compiler warnings for NLnetLabs#491. - Fix Wunused-result compile warnings. changelog PR NLnetLabs#491 rename var to remove shadow variable Apply suggestions from code review ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code path was causing segmentation faults by trying to call ev->vmt->winsock_tcp_wouldblock even though that was NULL