New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SVCB and HTTPS types and handling according to draft-ietf-dnsop-svcb-https #491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here a few things that I noticed immediately.
I'll continue review later...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues with str2ipv4hint
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
Also make internal auxilary functions static
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead with this code, for some of the fixup, the stack overflow and shadowed variable, I would want to check if the nsd svcb code has the same issue and fix it there similarly.
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
…rams >= MAX_NUMBER_OF_SVCPARAMS)
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go!
* nlnet/master: (175 commits) - Fix for older parsers for function call in serve expired get cached. - Another fix from lint for ignored return value. - Fix from lint for ignored return value. - Insert header into testcode/readzone.c, it was missing. - Introduce 'http-user-agent:' and 'hide-http-user-agent:' options. Revert "- With hide-version unbound also omits the version from http headers." - With hide-version unbound also omits the version from http headers. - review fix to remove duplicate error printout. - Fix unbound-control local_data and local_datas to print detailed syntax errors. - Fix spelling in localzone.h comment. - Fix spelling in doc/unbound.doxygen comment. - Fix for NLnetLabs#510: in depth, use ifdefs for windows api event calls. Don't call a function which hasn't been defined - iana portlist update. - Fix clang-analysis warnings for testcode/readzone.c. - Fix compiler warnings for NLnetLabs#491. - Fix Wunused-result compile warnings. changelog PR NLnetLabs#491 rename var to remove shadow variable Apply suggestions from code review ...
Draft pull request for draft-ietf-dnsop-svcb-https