Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVCB and HTTPS types and handling according to draft-ietf-dnsop-svcb-https #491

Merged
merged 40 commits into from
Jul 2, 2021

Conversation

TCY16
Copy link
Contributor

@TCY16 TCY16 commented May 21, 2021

Draft pull request for draft-ietf-dnsop-svcb-https

@wtoorop wtoorop marked this pull request as draft May 21, 2021 12:39
Copy link
Member

@wtoorop wtoorop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here a few things that I noticed immediately.
I'll continue review later...

sldns/rrdef.c Outdated Show resolved Hide resolved
sldns/rrdef.h Outdated Show resolved Hide resolved
sldns/wire2str.c Outdated Show resolved Hide resolved
sldns/wire2str.c Outdated Show resolved Hide resolved
sldns/wire2str.c Outdated Show resolved Hide resolved
Copy link
Member

@wtoorop wtoorop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues with str2ipv4hint

sldns/str2wire.c Outdated Show resolved Hide resolved
sldns/str2wire.c Outdated Show resolved Hide resolved
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
sldns/str2wire.c Outdated Show resolved Hide resolved
sldns/wire2str.c Outdated Show resolved Hide resolved
sldns/wire2str.c Outdated Show resolved Hide resolved
sldns/rrdef.c Show resolved Hide resolved
TCY16 and others added 2 commits June 24, 2021 09:45
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
sldns/str2wire.c Outdated Show resolved Hide resolved
TCY16 and others added 2 commits June 24, 2021 11:20
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
@TCY16 TCY16 requested a review from wcawijngaards June 24, 2021 13:36
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead with this code, for some of the fixup, the stack overflow and shadowed variable, I would want to check if the nsd svcb code has the same issue and fix it there similarly.

Makefile.in Show resolved Hide resolved
sldns/str2wire.c Outdated Show resolved Hide resolved
sldns/str2wire.c Outdated Show resolved Hide resolved
sldns/str2wire.c Outdated Show resolved Hide resolved
sldns/str2wire.c Outdated Show resolved Hide resolved
sldns/str2wire.c Outdated Show resolved Hide resolved
sldns/str2wire.c Outdated Show resolved Hide resolved
sldns/str2wire.c Outdated Show resolved Hide resolved
sldns/wire2str.c Outdated Show resolved Hide resolved
testcode/readzone.c Outdated Show resolved Hide resolved
TCY16 and others added 4 commits July 1, 2021 12:45
sldns/str2wire.c Outdated Show resolved Hide resolved
sldns/wire2str.c Outdated Show resolved Hide resolved
sldns/str2wire.c Outdated Show resolved Hide resolved
@TCY16 TCY16 marked this pull request as ready for review July 2, 2021 12:24
Copy link
Member

@wtoorop wtoorop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go!

@TCY16 TCY16 merged commit 379c7d5 into master Jul 2, 2021
TCY16 pushed a commit that referenced this pull request Jul 2, 2021
gthess added a commit that referenced this pull request Jul 5, 2021
jedisct1 added a commit to jedisct1/unbound that referenced this pull request Jul 27, 2021
* nlnet/master: (175 commits)
  - Fix for older parsers for function call in serve expired get cached.
  - Another fix from lint for ignored return value.
  - Fix from lint for ignored return value.
  - Insert header into testcode/readzone.c, it was missing.
  - Introduce 'http-user-agent:' and 'hide-http-user-agent:' options.
  Revert "- With hide-version unbound also omits the version from http headers."
  - With hide-version unbound also omits the version from http headers.
  - review fix to remove duplicate error printout.
  - Fix unbound-control local_data and local_datas to print detailed   syntax errors.
  - Fix spelling in localzone.h comment.
  - Fix spelling in doc/unbound.doxygen comment.
  - Fix for NLnetLabs#510: in depth, use ifdefs for windows api event calls.
  Don't call a function which hasn't been defined
  - iana portlist update.
  - Fix clang-analysis warnings for testcode/readzone.c.
  - Fix compiler warnings for NLnetLabs#491.
  - Fix Wunused-result compile warnings.
  changelog PR NLnetLabs#491
  rename var to remove shadow variable
  Apply suggestions from code review
  ...
@gthess gthess deleted the svcb branch November 30, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants