Add support for EDE caching in cachedb and subnetcache #790
+237
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2022 13:23
TCY16
changed the title
wcawijngaards
approved these changes
Dec 12, 2022
testdata/ede_caching_subnetcache.tdir/ede_caching_subnetcache.post
Outdated
Show resolved
Hide resolved
testdata/ede_caching_subnetcache.tdir/ede_caching_subnetcache.pre
Outdated
Show resolved
Hide resolved
|
it has been a while since you updated this (and other pull requests). It has been suggested by @gthess in my issue as a possible solution for the inconsistencies I experience, ref issue #873 I've compiled compiled the branche ede-caching-cachedb, there are some improvements, but I'm really waiting for all of your improvements to go into the master branch. Could you please take a look at the suggested changes and conflicts, in order to get these valuable additions back on track? Thanks for your time and effort. |
gthess
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
After addressing @wcawijngaards feedback and the recent changes, this seems ready now.
wcawijngaards
approved these changes
Jul 31, 2023
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Aug 11, 2023
* nlnet/master: (52 commits) - Move a cache reply callback in worker.c closer to the cache reply generation. - Fix to use the now cached EDE, if any, for CD_bit queries. - More braces and formatting for Fix for EDNS EDE size calculation to avoid future bugs. - Fix for EDNS EDE size calculation. - For NLnetLabs#911: Try to trim EXTRA-TEXT (and LDNS_EDE_OTHER options altogether) before giving up on attaching EDE options. - iana portlist update. - Merge NLnetLabs#790 from Tom Carpay: Add support for EDE caching in cachedb and subnetcache. - For NLnetLabs#790: Update formatting in cachedb/cachedb.c - For NLnetLabs#790: clean testcase. - For NLnetLabs#759: fix doc string. - Fix unused variable compile warning for kernel timestamps in netevent.c - Review for NLnetLabs#790: Fix memory leak. - Review for NLnetLabs#790: Address Wouter's comments. - Review for NLnetLabs#790: replace tdir tests with simpler rpl tests. Address review comments for NLnetLabs#759: - Clear error text when an expected signature is missing. Address review comments for NLnetLabs#759: - Decrease allocations for "" EDE strings when loading the cachedump. - Check for existence of EDE code before attaching. - For NLnetLabs#889: Account for num_detached_states before possible mesh_state_delete when erroring out. - For NLnetLabs#889: use netcat-openbsd instead of netcat-traditional. - Cleaner failure code for callback functions in interface.i. Log established connection to Redis ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a child of #759.