-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EDE caching in cachedb and subnetcache #790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added a couple suggestions that may make it nicer. It is nice to also support the cachedb and subnetcache for EDE error strings.
testdata/ede_caching_subnetcache.tdir/ede_caching_subnetcache.post
Outdated
Show resolved
Hide resolved
testdata/ede_caching_subnetcache.tdir/ede_caching_subnetcache.pre
Outdated
Show resolved
Hide resolved
it has been a while since you updated this (and other pull requests). It has been suggested by @gthess in my issue as a possible solution for the inconsistencies I experience, ref issue #873 I've compiled compiled the branche ede-caching-cachedb, there are some improvements, but I'm really waiting for all of your improvements to go into the master branch. Could you please take a look at the suggested changes and conflicts, in order to get these valuable additions back on track? Thanks for your time and effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After addressing @wcawijngaards feedback and the recent changes, this seems ready now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intervening commits are good fixes, in my opinion.
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
* nlnet/master: (52 commits) - Move a cache reply callback in worker.c closer to the cache reply generation. - Fix to use the now cached EDE, if any, for CD_bit queries. - More braces and formatting for Fix for EDNS EDE size calculation to avoid future bugs. - Fix for EDNS EDE size calculation. - For NLnetLabs#911: Try to trim EXTRA-TEXT (and LDNS_EDE_OTHER options altogether) before giving up on attaching EDE options. - iana portlist update. - Merge NLnetLabs#790 from Tom Carpay: Add support for EDE caching in cachedb and subnetcache. - For NLnetLabs#790: Update formatting in cachedb/cachedb.c - For NLnetLabs#790: clean testcase. - For NLnetLabs#759: fix doc string. - Fix unused variable compile warning for kernel timestamps in netevent.c - Review for NLnetLabs#790: Fix memory leak. - Review for NLnetLabs#790: Address Wouter's comments. - Review for NLnetLabs#790: replace tdir tests with simpler rpl tests. Address review comments for NLnetLabs#759: - Clear error text when an expected signature is missing. Address review comments for NLnetLabs#759: - Decrease allocations for "" EDE strings when loading the cachedump. - Check for existence of EDE code before attaching. - For NLnetLabs#889: Account for num_detached_states before possible mesh_state_delete when erroring out. - For NLnetLabs#889: use netcat-openbsd instead of netcat-traditional. - Cleaner failure code for callback functions in interface.i. Log established connection to Redis ...
This PR is a child of #759.