Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbound won't build with aaaa-filter-iterator.patch #841

Closed
Jakker opened this issue Feb 8, 2023 · 1 comment
Closed

Unbound won't build with aaaa-filter-iterator.patch #841

Jakker opened this issue Feb 8, 2023 · 1 comment

Comments

@Jakker
Copy link
Contributor

Jakker commented Feb 8, 2023

Applying the aaaa-filter-iterator.patch will break compiling unbound. It can be fixed with patchin the patch:

--- aaaa-filter-iterator.patch	2023-02-08 11:19:38.869425000 +0100
+++ aaaa-filter-iterator.patch.orig	2023-01-12 09:18:31.000000000 +0100
@@ -108,8 +108,6 @@
  	iter_env->supports_ipv6 = cfg->do_ip6;
  	iter_env->supports_ipv4 = cfg->do_ip4;
  	iter_env->outbound_msg_retry = cfg->outbound_msg_retry;
- 	iter_env->max_sent_count = cfg->max_sent_count;
- 	iter_env->max_query_restarts = cfg->max_query_restarts;
 +	iter_env->aaaa_filter = cfg->aaaa_filter;
  	return 1;
  }

See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269337
@wcawijngaards
Copy link
Member

Yes that patch works, if it is applied in reverse. I also adjusted it so that the context lines are three lines instead of five. With that change the patch applies and unbound compiles.

jedisct1 added a commit to jedisct1/unbound that referenced this issue Feb 15, 2023
@jedisct1
Merge remote-tracking branch 'nlnet/master'
81dd024 
* nlnet/master:
  Changelog entry for - Clean up iterator/iterator.c::error_response_cache() and allow for   better interaction with serve-expired, prefetch and cached error   responses.
  - Clean up iterator/iterator.c::error_response_cache() and allow for   better interaction with serve-expired, prefetch and cached error   responses.
  - Add testcase for refreshing expired error responses.
  - Fix to git ignore the library symbol file that configure can create.
  - Fix consistency of unit test without roundrobin answers for the   cnametooptout unit test.
  Changelog entry for - Allow TTL refresh of expired error responses.
  - Allow TTL refresh of expired error responses.
  - Fix unit tests for spurious empty messages.
  - Fix to ignore entirely empty responses, and try at another authority.   This turns completely empty responses, a type of noerror/nodata into   a servfail, but they do not conform to RFC2308, and the retry can   fetch improved content.
  - Fix NLnetLabs#841: Unbound won't build with aaaa-filter-iterator.patch.
  - Add duration variable for speed_local.test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wcawijngaards @Jakker