Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #851

Closed
elfring opened this issue Feb 23, 2023 · 2 comments
Closed

reserved identifier violation #851

elfring opened this issue Feb 23, 2023 · 2 comments

Comments

@elfring
Copy link

elfring commented Feb 23, 2023

I would like to point out that an identifier like “_UB_UNBOUND_EVENT_H” does eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
Philip-NLnetLabs added a commit that referenced this issue Mar 21, 2023
@Philip-NLnetLabs
Fix issue #851: reserved identifier violation
6108757
Philip-NLnetLabs added a commit that referenced this issue Mar 21, 2023
@Philip-NLnetLabs
Fix issue #851: reserved identifier violation
2a100ee
Philip-NLnetLabs added a commit that referenced this issue Mar 21, 2023
@Philip-NLnetLabs
Changelog for issue #851
e850ca6
@Philip-NLnetLabs
Copy link
Member

Fixed in master

@elfring
Copy link
Author

elfring commented Mar 21, 2023

Thanks for your adjustment of affected include guards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @Philip-NLnetLabs