Error: util/configlexer.c: No such file or directory

[origamiofficial]

Describe the bug
Recently unbound started failing to compile. It shows gcc: error: util/configlexer.c: No such file or directory. I've got a Docker project pihole-unbound that builds images using GitHub Actions and was building fine for 9 Months. But recently the build has started failing. Seems unbound issue. Full log available on Run #223

To reproduce
Steps to reproduce the behavior:

1. Compile unbound

Expected behavior
Compile fine and build complete.

System:

• Unbound version: Latest (Repo Sync)
• OS: Debian bullseye
• unbound -V output: Compile Failed!

Compile Log

> [linux/amd64 unbound 4/4] RUN build_deps="curl gcc libc-dev libevent-dev libexpat1-dev libnghttp2-dev make bison" &&     set -x &&     DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y --no-install-recommends       $build_deps       bsdmainutils       ca-certificates       ldnsutils       libevent-2.1-7       libexpat1       libprotobuf-c-dev       protobuf-c-compiler &&     git clone https://github.com/NLnetLabs/unbound.git &&     cd unbound &&     groupadd _unbound &&     useradd -g _unbound -s /dev/null -d /etc _unbound &&     ./configure         --disable-dependency-tracking         --prefix=/opt/unbound         --with-pthreads         --with-username=_unbound         --with-ssl=/opt/openssl         --with-libevent         --with-libnghttp2         --enable-dnstap         --enable-tfo-server         --enable-tfo-client         --enable-event-api         --enable-subnet &&     make install &&     mv /opt/unbound/etc/unbound/unbound.conf /opt/unbound/etc/unbound/unbound.conf.example &&     apt-get purge -y --auto-remove       $build_deps &&     rm -rf         /opt/unbound/share/man         /tmp/*         /var/tmp/*         /var/lib/apt/lists/*:
#24 141.4 	echo "#include \"config.h\"" > util/configlexer.c ;\
#24 141.4 	echo "#include \"util/configyyrename.h\"" >> util/configlexer.c ;\
#24 141.4 	: -t ./util/configlexer.lex >> util/configlexer.c ;\
#24 141.4 fi
#24 141.4 ./libtool --tag=CC --mode=compile gcc -I.  -I/opt/openssl/include -DSRCDIR=. -g -O2 -flto -pthread -I/usr/include/google  -o configlexer.lo -c util/configlexer.c
#24 141.5 libtool: compile:  gcc -I. -I/opt/openssl/include -DSRCDIR=. -g -O2 -flto -pthread -I/usr/include/google -c util/configlexer.c  -fPIC -DPIC -o .libs/configlexer.o
#24 141.5 gcc: error: util/configlexer.c: No such file or directory
#24 141.5 gcc: fatal error: no input files
#24 141.5 compilation terminated.
#24 141.5 make: *** [Makefile:319: configlexer.lo] Error 1
------
Dockerfile:36
--------------------
  35 |     
  36 | >>> RUN build_deps="curl gcc libc-dev libevent-dev libexpat1-dev libnghttp2-dev make bison" && \
  37 | >>>     set -x && \
  38 | >>>     DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y --no-install-recommends \
  39 | >>>       $build_deps \
  40 | >>>       bsdmainutils \
  41 | >>>       ca-certificates \
  42 | >>>       ldnsutils \
  43 | >>>       libevent-2.1-7 \
  44 | >>>       libexpat1 \
  45 | >>>       libprotobuf-c-dev \
  46 | >>>       protobuf-c-compiler && \
  47 | >>>     git clone https://github.com/NLnetLabs/unbound.git && \
  48 | >>>     cd unbound && \
  49 | >>>     groupadd _unbound && \
  50 | >>>     useradd -g _unbound -s /dev/null -d /etc _unbound && \
  51 | >>>     ./configure \
  52 | >>>         --disable-dependency-tracking \
  53 | >>>         --prefix=/opt/unbound \
  54 | >>>         --with-pthreads \
  55 | >>>         --with-username=_unbound \
  56 | >>>         --with-ssl=/opt/openssl \
  57 | >>>         --with-libevent \
  58 | >>>         --with-libnghttp2 \
  59 | >>>         --enable-dnstap \
  60 | >>>         --enable-tfo-server \
  61 | >>>         --enable-tfo-client \
  62 | >>>         --enable-event-api \
  63 | >>>         --enable-subnet && \
  64 | >>>     make install && \
  65 | >>>     mv /opt/unbound/etc/unbound/unbound.conf /opt/unbound/etc/unbound/unbound.conf.example && \
  66 | >>>     apt-get purge -y --auto-remove \
  67 | >>>       $build_deps && \
  68 | >>>     rm -rf \
  69 | >>>         /opt/unbound/share/man \
  70 | >>>         /tmp/* \
  71 | >>>         /var/tmp/* \
  72 | >>>         /var/lib/apt/lists/*
  73 |     
--------------------
ERROR: failed to solve: process "/bin/bash -c build_deps=\"curl gcc libc-dev libevent-dev libexpat1-dev libnghttp2-dev make bison\" &&     set -x &&     DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y --no-install-recommends       $build_deps       bsdmainutils       ca-certificates       ldnsutils       libevent-2.1-7       libexpat1       libprotobuf-c-dev       protobuf-c-compiler &&     git clone https://github.com/NLnetLabs/unbound.git &&     cd unbound &&     groupadd _unbound &&     useradd -g _unbound -s /dev/null -d /etc _unbound &&     ./configure         --disable-dependency-tracking         --prefix=/opt/unbound         --with-pthreads         --with-username=_unbound         --with-ssl=/opt/openssl         --with-libevent         --with-libnghttp2         --enable-dnstap         --enable-tfo-server         --enable-tfo-client         --enable-event-api         --enable-subnet &&     make install &&     mv /opt/unbound/etc/unbound/unbound.conf /opt/unbound/etc/unbound/unbound.conf.example &&     apt-get purge -y --auto-remove       $build_deps &&     rm -rf         /opt/unbound/share/man         /tmp/*         /var/tmp/*         /var/lib/apt/lists/*" did not complete successfully: exit code: 2
Error: buildx failed with: ERROR: failed to solve: process "/bin/bash -c build_deps=\"curl gcc libc-dev libevent-dev libexpat1-dev libnghttp2-dev make bison\" &&     set -x &&     DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y --no-install-recommends       $build_deps       bsdmainutils       ca-certificates       ldnsutils       libevent-2.1-7       libexpat1       libprotobuf-c-dev       protobuf-c-compiler &&     git clone https://github.com/NLnetLabs/unbound.git &&     cd unbound &&     groupadd _unbound &&     useradd -g _unbound -s /dev/null -d /etc _unbound &&     ./configure         --disable-dependency-tracking         --prefix=/opt/unbound         --with-pthreads         --with-username=_unbound         --with-ssl=/opt/openssl         --with-libevent         --with-libnghttp2         --enable-dnstap         --enable-tfo-server         --enable-tfo-client         --enable-event-api         --enable-subnet &&     make install &&     mv /opt/unbound/etc/unbound/unbound.conf /opt/unbound/etc/unbound/unbound.conf.example &&     apt-get purge -y --auto-remove       $build_deps &&     rm -rf         /opt/unbound/share/man         /tmp/*         /var/tmp/*         /var/lib/apt/lists/*" did not complete successfully: exit code: 2

[wcawijngaards]

The error happens because a recent code contribution removed the generated lexer and parser files from the code repository. With installed flex and bison, the files are created during the compile.

Thanks for the report! It would be nice to have readable explanatory output for this. The fixup prints understandable error messages, explaining that flex and bison are needed to compile the code from the source repository. For compiles from source tarballs, the generated files in the release tarball can be used. For the build process in the issue ticket, append flex bison to the apt-get install -y line, or add it to the build_deps variable. Here is a diff for docker-pihole-unbound/latest/Dockerfile, that adds flex to the build dependencies:

--- Dockerfile.orig	2023-05-04 11:22:45.305097778 +0200
+++ Dockerfile.new	2023-05-04 11:23:13.055096312 +0200
@@ -33,7 +33,7 @@
 
 COPY --from=openssl /opt/openssl /opt/openssl
 
-RUN build_deps="curl gcc libc-dev libevent-dev libexpat1-dev libnghttp2-dev make bison" && \
+RUN build_deps="curl gcc libc-dev libevent-dev libexpat1-dev libnghttp2-dev make flex bison" && \
     set -x && \
     DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y --no-install-recommends \
       $build_deps \

[origamiofficial]

Thanks for the fix!!