Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unbound 1.18.0 make test error #927

Closed
oukb opened this issue Aug 31, 2023 · 1 comment
Closed

unbound 1.18.0 make test error #927

oukb opened this issue Aug 31, 2023 · 1 comment

Comments

@oukb
Copy link

oukb commented Aug 31, 2023 •
edited
Loading

Hi

Unbound 1.18.0
make test error on Centos/RHEL 8/9

Aug 31 09:54:47 unbound[11727:0] debug: query took 0.000000 sec
Aug 31 09:54:47 unbound[11727:0] info: mesh_run: end 0 recursion states (0 with reply, 0 detached), 0 waiting replies, 1 recursion replies sent, 0 replies dropped, 0 states jostled out
Aug 31 09:54:47 unbound[11727:0] info: average recursion processing time 0.000000 sec
Aug 31 09:54:47 unbound[11727:0] info: histogram of recursion processing times
Aug 31 09:54:47 unbound[11727:0] info: [25%]=0 median[50%]=0 [75%]=0
Aug 31 09:54:47 unbound[11727:0] info: lower(secs) upper(secs) recursions
Aug 31 09:54:47 unbound[11727:0] info:    0.000000    0.000001 1
Aug 31 09:54:47 unbound[11727:0] debug: cache memory msg=67215 rrset=68862 infra=7904 val=66591 subnet=74536
Aug 31 09:54:47 unbound[11727:0] info: testbound: end of event stage
Aug 31 09:54:47 unbound[11727:0] debug: comparepkt: 
Aug 31 09:54:47 unbound[11727:0] debug: bad EDE INFO-CODE. Expected: 6, and got: 7

Aug 31 09:54:47 unbound[11727:0] info: testbound: do STEP 20 CHECK_ANSWER
Aug 31 09:54:47 unbound[11727:0] fatal error: testbound: not matched 
./testdata/autotrust_init_failsig.rpl  failed

Logs:
https://download.copr.fedorainfracloud.org/results/fcsm/unbound/epel-8-x86_64/06358703-unbound/builder-live.log.gz
https://download.copr.fedorainfracloud.org/results/fcsm/unbound/epel-9-x86_64/06358703-unbound/builder-live.log.gz

and no error on fedora 37-39:
https://download.copr.fedorainfracloud.org/results/fcsm/unbound/fedora-38-x86_64/06358703-unbound/builder-live.log.gz
@wcawijngaards
Copy link
Member

The commit fixes it, by changing the test to be lenient for SHA1 support. Without SHA1 the DNSSEC failure EDE error code differs from when there is SHA1 support, and this caused the test to error out. The change allows the different EDE code.

Likely this is what causes the difference, depending on the platforms support. The issue should be fixed with this. The issue can be replicated with --disable-sha1. Thanks for the report!

jedisct1 added a commit to jedisct1/unbound that referenced this issue Sep 4, 2023
@jedisct1
Merge remote-tracking branch 'nlnet/master'
204d3d8 
* nlnet/master: (44 commits)
  - Fix NLnetLabs#927: unbound 1.18.0 make test error. Fix make test without SHA1.
  - Fix autoconf 2.69 warnings in configure.
  - Fix for WKS call to getservbyname that creates allocation on exit   in unit test by testing numbers first and testing from the services   list later.
  Tag 1.18.0rc1 became the 1.18.0 release on 30 aug 2023, with the fix from 25 aug, fix compile on NetBSD included. The repository continues with version 1.18.1.
  - Fix for version generation race condition that ignored changes.
  - Fix compile error on NetBSD in util/netevent.h.
  - Tag for 1.18.0rc1 release.
  - Set version number to 1.18.0.
  - Fix unit test for unbound-control to work when threads are disabled,   and fix cache dump check.
  - Fix NLnetLabs#923: processQueryResponse() THROWAWAY should be mindful of   fail_reply.
  - Fix for NLnetLabs#925: unbound.service: Main process exited, code=killed,   status=11/SEGV. Fixes cachedb configuration handling.
  - Fix windows ci workflow to install bison and flex.
  Further debug for windows ci workflow.
  - Debug Windows ci workflow.
  - Fix stat_values test to work with dig that enables DNS cookies.
  - Fix uninitialized memory passed in padding bytes of cmsg to sendmsg.
  Changelog for commit. - Fix for iter_dec_attempts that could cause a hang, part of   capsforid and qname minimisation, depending on the settings.
  - Fix for iter_dec_attempts that could cause a hang, part of   capsforid and qname minimisation, depending on the settings.
  - Fix ip_ratelimit test to work with dig that enables DNS cookies.
  - Fix regional_alloc_init for potential unaligned source of the copy.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wcawijngaards @oukb