DoH: reject non-h2 early #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, non-h2 connections would be accepted, and then error out with a verbose message "http2: session_recv from ____ failed, error: Received bad client magic byte string". Instead, we can detect absence of h2 support at connection time and reject with a clearer verbose message.
wcawijngaards
approved these changes
Jan 3, 2024
|
The fix makes a nicer error output, so that is a nice improvement! It is merged into the code repository. |
wcawijngaards
added a commit
that referenced
this pull request
Jan 3, 2024
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 7, 2024
* nlnet/master: (40 commits) - Fix unit test for NLnetLabs#987 change in udp1xxx retry packet send. Changelog note for NLnetLabs#987 - Merge NLnetLabs#987: skip edns frag retry if advertised udp payload size is not smaller. skip edns frag retry if advertised udp payload size is not smaller - Remove unneeded newlines and improve indentation in remote control code. - Fix NLnetLabs#983: Sha1 runtime insecure change was incomplete. Changelog note for NLnetLabs#985. - Merge NLnetLabs#985: Add DoH and DoT to dnstap message. Changelog note for NLnetLabs#979 and NLnetLabs#980. - Merge NLnetLabs#980: DoH: reject non-h2 early. To fix NLnetLabs#979: Improve errors for non-HTTP/2 DoH clients. Add DoH and DoT to dnstap message - Update example.conf with cookie options. DoH: reject non-h2 early Fixup doc/Changelog. - Fix root_zonemd unit test, it checks that the root ZONEMD verifies, now that the root has a valid ZONEMD. Changelog note for NLnetLabs#975 - Merge NLnetLabs#975: Fixed some syntax errors in rpl files. Fixed some syntax errors in rpl files. - Fix NLnetLabs#974: doc: default number of outgoing ports without libevent. - Use the origin (DNAME) TTL for syntesized CNAMEs as per RFC 6672. - Fix tests to use new common.sh functions, wait_logfile and kill_from_pidfile. - Update test script file common.sh. - Updated IPv4 and IPv6 address for b.root-servers.net in root hints. - iana portlist update. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, non-h2 connections would be accepted, and then error out with a verbose message "http2: session_recv from ____ failed, error: Received bad client magic byte string". Instead, we can detect absence of h2 support at connection time and reject with a clearer verbose message.
Partial fix for #979