Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ip-dscp option to specify the DSCP tag for outgoing packets #184

Closed
wants to merge 2 commits into from

Conversation

yarikk
Copy link
Contributor

@yarikk yarikk commented Mar 5, 2020

DSCP, the Differentiated Services codepoint, is a field in the IP header packets used for QoS. It replaces the obsolete TOS field in IPv4 and the Traffic Class field in IPv6, per RFC 3260.

Let's add ip-dscp server option to specify an integer value to be passed to setsockopt(…, IP_TOS, …) for every internet-family socket created, effectively enabling the QoS tagging of all outgoing packets.

Parsing of the new option confirmed with unbound-checkconf on testdata/04-checkconf.tdir/good.all and testdata/04-checkconf.tdir/bad.dscp.

cc @ralphdolmans @chantra

@ralphdolmans ralphdolmans self-assigned this Mar 5, 2020
wcawijngaards added a commit that referenced this pull request Mar 5, 2020
- Fix PR #184 from noloader: Add iOS testing to Travis.
wcawijngaards added a commit that referenced this pull request Mar 5, 2020
@yarikk
Copy link
Contributor Author

yarikk commented Mar 12, 2020

This requires more work – will submit a new PR when ready. Abandoning this one.

@yarikk yarikk closed this Mar 12, 2020
jedisct1 added a commit to jedisct1/unbound that referenced this pull request Mar 20, 2020
* nlnet/master: (149 commits)
  - Fix .travis.yml error, missing 'env' option.
  - Merge PR#194: Add libevent testing to Travis, by Jeffrey Walton.
  Add changelog entries for PR#134.
  - Log warning when using outgoing-port-permit and outgoing-port-avoid   while explicit port randomisation is disabled.
  - Fix NLnetLabs#158: open tls-session-ticket-keys as binary, for Windows. By Daisuke   HIGASHI.
  - Merge PR#191: Update iOS testing on Travis, by Jeffrey Walton.
  Add libevent testing to Travis
  Sync with upstream
  - Fix NLnetLabs#192: In the unbound-checkconf tool, the module config of   dns64 subnetcache respip validator iterator is whitelisted, it was   reported it seems to work.
  - Fix compile of test tools without protobuf.
  - Add check to make sure RPZ records are subdomain of configured zone origin.
  - Changelog entry for (Fix NLnetLabs#189, Merge PR NLnetLabs#190).
  Changelog for NLnetLabs#188 and configure script created.  Removed unneeded whitespace.
  Fix NLnetLabs#188: unbound-control.c:882:6: error: 'execlp' is unavailable: not available on tvOS
  Fix NetBSD compile (GH NLnetLabs#189)
  - Changelog note for PR NLnetLabs#186: Fix unrecognized 'echo -n' option on OS X,   by noloader.
  Fix unrecognized 'echo -n' option on OS X Also see NLnetLabs#183. This PR also updates a few typos in README-Travis.md, and expands the discussion of PKG_CONFIG_PATH for those who are not familiar with it.
  Fix changelog note, it is NLnetLabs#182, not NLnetLabs#184.
  Changelog note for NLnetLabs#184. - Fix PR NLnetLabs#184 from noloader: Add iOS testing to Travis.
  Add iOS testing to Travis
  ...
@yarikk
Copy link
Contributor Author

yarikk commented Mar 23, 2020

Replaced with PR #200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants