Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upstream cookie support #683

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add upstream cookie support #683

wants to merge 23 commits into from

Conversation

TCY16
Copy link
Contributor

@TCY16 TCY16 commented May 26, 2022

  • Create .rpl test with required changed in testbound
  • Make cookies privacy aware (i.e. exclusive per source IP address)
    • Make test for privacy aware cookies
  • Make upstream cookies configurable

@TCY16 TCY16 self-assigned this May 26, 2022
@TCY16 TCY16 changed the title Add upstream and downstream cookie support Add upstream cookie support May 30, 2022
@TCY16 TCY16 force-pushed the features/upstream-cookies branch from f5f8060 to aebf1db Compare July 1, 2022 13:38
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I noticed some debug and todo comments and debug log prints, and made some suggestions in the items. The code looks nice. The .rpl file does not exercise the outside_network code, but it is not that big a part of the code.

services/cache/infra.c Outdated Show resolved Hide resolved
services/cache/infra.c Outdated Show resolved Hide resolved
services/cache/infra.c Outdated Show resolved Hide resolved
services/cache/infra.h Outdated Show resolved Hide resolved
services/cache/infra.h Outdated Show resolved Hide resolved
testcode/testpkts.c Show resolved Hide resolved
testcode/testpkts.c Show resolved Hide resolved
testcode/testpkts.c Outdated Show resolved Hide resolved
testcode/testpkts.c Outdated Show resolved Hide resolved
testcode/unitmain.c Show resolved Hide resolved
@TCY16 TCY16 requested a review from wtoorop August 16, 2022 09:35
@gthess gthess added this to the 1.18.0 milestone Mar 17, 2023
@gthess gthess modified the milestones: 1.18.0, Future release Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants