NXNS fallback #706
Merged
NXNS fallback #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also allow MAX_TARGET_NX more NXDOMAINs.
wcawijngaards
approved these changes
Jun 30, 2022
iterator/iterator.c
Outdated
| * This also marks the fallback activation. */ | ||
| *iq->nxns_dp = malloc(iq->dp->namelen); | ||
| if(!*iq->nxns_dp) { | ||
| errinf(qstate, "exceeded the maximum nameserver nxdomains"); |
There was a problem hiding this comment.
The error is out of memory, that malloc failed. While also it exceeded the maximum nameserver nxdomains.
|
Thanks! I improved the logging for the fallback (also to accommodate for the review comment), waiting for the test action to finish and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables fallback to the parent side when a delegation point has reached the MAX_TARGET_NX limit in case more useful information is found there.
It will allow for MAX_TARGET_NX NXDOMAINs more (for this and the other shared queries) to ease resolution.
Cached NXDOMAIN also no longer count for the MAX_TARGET_NX limit.
Additional fixes that come along: