Improve Windows NSIS installer script (setup.nsi) #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two improvements of installer script : - avoid error message when Unbound is running, - add "DisplayVersion" in registry thus Windows package manager (Winget) can handle Unbound. Avoid error message : When Unbound is already installed and running, when the installer is used to update Unbund, it displays an error message "Error opening file for writing". In order to avoid this message, I suggest a modification to stop Unbound service if already installed. Adding "DisplayVersion" in registry : Winget use uninstall parameters in Windows registry to get program versions to be able to compare installed version and last available version to propose update. Without this parameter, Winget can't handle Unbound updates. This parameter is also used to show program versions in the Windows remove program menu. I suggest adding this parameter in the installer script.
|
Hi, I like change no2 but not no1 :) |
Ask user to stop Unbound to permit the update
For no1 I can suggest adding a messagebox to ask user : |
|
I like it more, but maybe instead of Abort just Quit? |
… Windows registry
|
Yes, simply Quit is much more adapted, have modified it. |
gthess
added a commit
that referenced
this pull request
Mar 25, 2024
- Merge #831 from Pierre4012: Improve Windows NSIS installer script (setup.nsi).
gthess
added a commit
that referenced
this pull request
Mar 25, 2024
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Apr 4, 2024
* nlnet/master: (24 commits) - Fix NLnetLabs#369: dnstap showing extra responses; for client responses right from the cache when replying with expired data or prefetching. - Fix NLnetLabs#1035: Potential Bug while parsing port from the "stub-host" string; also affected forward-zones and remote-control host directives. - For NLnetLabs#1040: adjust error text and disallow negative ports in other parts of cfg_mark_ports. Changelog note for NLnetLabs#1040 - Fix NLnetLabs#1040: fix heap-buffer-overflow issue in function cfg_mark_ports of file util/config_file.c. fix heap-buffer-overflow issue in function cfg_mark_ports of file util/config_file.c - Fix for crypto related failures to have a better error string. - Fix NLnetLabs#1034: DoT forward-zone via unbound-control. - Fix that the server does not chown the pidfile. - Fix that when the server truncates the pidfile, it does not follow symbolic links. - Fix to add unit test for lruhash space that exercises the routines. - Fix comment in lruhash space function. - Fix for NLnetLabs#1032, add safeguard to make table space positive. - Fix NLnetLabs#1032: The size of subnet_msg_cache calculation mistake cause memory usage increased beyond expectations. - Fix name of unit test for subnet cache response. - For NLnetLabs#831: Format text, use exclamation icon and explicit label names. Changelog entry for NLnetLabs#831 - Merge NLnetLabs#831 from Pierre4012: Improve Windows NSIS installer script (setup.nsi). Improve Windows NSIS installer script (setup.nsi) (NLnetLabs#831) - Fix localdata and rpz localdata to match CNAME only if no direct type match is available. - Fix rpz so that rpz CNAME can apply after rpz CNAME. And fix that clientip and nsip can give a CNAME. - Fix rpz for qtype CNAME after nameserver trigger. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two improvements of installer script :
1. Avoid error message :
When Unbound is already installed and running, when the installer is used to update Unbund, it displays an error message :
In order to avoid this message, I suggest a modification to stop Unbound service if already installed.
2. Adding "DisplayVersion" in registry :
Winget use uninstall parameters in Windows registry to get program versions to be able to compare installed version and last available version to propose update. Without this parameter, Winget can't handle Unbound updates :
This parameter is also used to show program versions in the Windows remove program menu.
I suggest adding this parameter in the installer script.