Add kill capability to systemd service file #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ExecReload command calls kills on a process owned by the unbound user (or whatever user is configured). To do so, it needs the CAP_KILL capability.
wcawijngaards
added a commit
that referenced
this pull request
Sep 23, 2019
|
Thanks! Noticed that Maryse47 likes it and that was the contributor for the previous service file changes. So it looks good, merged. |
Closed
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Oct 1, 2019
* nlnet/master: Changelog note for NLnetLabs#87. - Merge NLnetLabs#87 from hardfalcon: Fix contrib/unbound.service.in, Drop CAP_KILL, use + prefix for ExecReload= instead. Drop CAP_KILL, use + prefix for ExecReload= instead - The unbound.conf includes are sorted ascending, for include statements with a '*' from glob. Changelog entry for fix NLnetLabs#84 and NLnetLabs#85. - Merge NLnetLabs#85 for NLnetLabs#84 from sam-lunt: Add kill capability to systemd service file to fix that systemctl reload fails. Add kill capability to systemd service file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this issue, the ExecReload command calls kills on a process owned by the unbound user (or whatever user is configured). To do so, it needs the CAP_KILL capability. I think adding this capability to the systemd unit makes sense, since it's using
killright there in the unit file. Additionally, since the process does not run asroot, the extra capability will be dropped by the main process after start up