Better missing httpcontext reporting & Skip null-check of HttpContextAccessor.HttpContext in DoAppend #314

snakefoot · 2018-09-16T08:47:55Z

Has been checked

snakefoot · 2018-09-18T19:05:42Z

It would actually be really nice if it didn't have to allocate / unwrap the HttpContextWrapper two times in AspNetLayoutRendererBase.

It performs a nullcheck and then the specialized version has to allocate / unwrap the HttpContextWrapper again.

codecov · 2018-09-18T19:30:31Z

Codecov Report

Merging #314 into master will increase coverage by 1%.
The diff coverage is 60%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +1%     
=====================================
  Files          31     31           
  Lines         399    413   +14     
  Branches       95     89    -6     
=====================================
+ Hits          233    246   +13     
- Misses        128    136    +8     
+ Partials       38     31    -7

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs	`92% <100%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...8de37e5. Read the comment docs.

codecov · 2018-09-18T19:34:15Z

Codecov Report

Merging #314 into master will increase coverage by 1%.
The diff coverage is 60%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +1%     
=====================================
  Files          31     31           
  Lines         399    413   +14     
  Branches       95     89    -6     
=====================================
+ Hits          233    246   +13     
- Misses        128    136    +8     
+ Partials       38     31    -7

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs	`92% <100%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...ffa332e. Read the comment docs.

codecov · 2018-09-18T19:35:58Z

Codecov Report

Merging #314 into master will increase coverage by 1%.
The diff coverage is 62%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +1%     
=====================================
  Files          31     31           
  Lines         399    414   +15     
  Branches       95     89    -6     
=====================================
+ Hits          233    247   +14     
- Misses        128    136    +8     
+ Partials       38     31    -7

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs	`92% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...ffa332e. Read the comment docs.

codecov · 2018-09-18T19:38:25Z

Codecov Report

Merging #314 into master will increase coverage by 1%.
The diff coverage is 62%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +1%     
=====================================
  Files          31     31           
  Lines         399    414   +15     
  Branches       95     89    -6     
=====================================
+ Hits          233    247   +14     
- Misses        128    136    +8     
+ Partials       38     31    -7

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs	`92% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...ffa332e. Read the comment docs.

codecov · 2018-09-18T19:41:46Z

Codecov Report

Merging #314 into master will increase coverage by 2%.
The diff coverage is 63%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +2%     
=====================================
  Files          31     31           
  Lines         399    414   +15     
  Branches       95     88    -7     
=====================================
+ Hits          233    248   +15     
- Misses        128    136    +8     
+ Partials       38     30    -8

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs	`95% <100%> (+3%)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...ffa332e. Read the comment docs.

codecov · 2018-09-18T19:41:50Z

Codecov Report

Merging #314 into master will increase coverage by 2%.
The diff coverage is 63%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +2%     
=====================================
  Files          31     31           
  Lines         399    414   +15     
  Branches       95     88    -7     
=====================================
+ Hits          233    248   +15     
- Misses        128    136    +8     
+ Partials       38     30    -8

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs	`95% <100%> (+3%)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...ffa332e. Read the comment docs.

codecov · 2018-09-18T19:42:20Z

Codecov Report

Merging #314 into master will increase coverage by 2%.
The diff coverage is 63%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +2%     
=====================================
  Files          31     31           
  Lines         399    414   +15     
  Branches       95     88    -7     
=====================================
+ Hits          233    248   +15     
- Misses        128    136    +8     
+ Partials       38     30    -8

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs	`95% <100%> (+3%)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...885c38b. Read the comment docs.

codecov · 2018-09-18T19:42:51Z

Codecov Report

Merging #314 into master will increase coverage by 2%.
The diff coverage is 63%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +2%     
=====================================
  Files          31     31           
  Lines         399    414   +15     
  Branches       95     88    -7     
=====================================
+ Hits          233    248   +15     
- Misses        128    136    +8     
+ Partials       38     30    -8

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs	`95% <100%> (+3%)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...885c38b. Read the comment docs.

codecov · 2018-09-18T19:44:55Z

Codecov Report

Merging #314 into master will increase coverage by 2%.
The diff coverage is 63%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +2%     
=====================================
  Files          31     31           
  Lines         399    414   +15     
  Branches       95     88    -7     
=====================================
+ Hits          233    248   +15     
- Misses        128    136    +8     
+ Partials       38     30    -8

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs	`95% <100%> (+3%)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...7c6d88e. Read the comment docs.

codecov · 2018-09-18T19:46:03Z

Codecov Report

Merging #314 into master will increase coverage by 2%.
The diff coverage is 63%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +2%     
=====================================
  Files          31     31           
  Lines         399    414   +15     
  Branches       95     88    -7     
=====================================
+ Hits          233    248   +15     
- Misses        128    136    +8     
+ Partials       38     30    -8

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...7c6d88e. Read the comment docs.

codecov · 2018-09-18T19:48:57Z

Codecov Report

Merging #314 into master will increase coverage by 2%.
The diff coverage is 63%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +2%     
=====================================
  Files          31     31           
  Lines         399    414   +15     
  Branches       95     88    -7     
=====================================
+ Hits          233    248   +15     
- Misses        128    136    +8     
+ Partials       38     30    -8

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...tRenderers/AspNetApplicationValueLayoutRenderer.cs	`100% <100%> (+25%)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...7c6d88e. Read the comment docs.

codecov · 2018-09-18T19:51:56Z

Codecov Report

Merging #314 into master will increase coverage by 1%.
The diff coverage is 62%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +1%     
=====================================
  Files          31     31           
  Lines         399    416   +17     
  Branches       95     89    -6     
=====================================
+ Hits          233    248   +15     
- Misses        128    137    +9     
+ Partials       38     31    -7

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
...e/LayoutRenderers/AspNetRequestReferrerRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...7c6d88e. Read the comment docs.

codecov · 2018-09-18T19:53:56Z

Codecov Report

Merging #314 into master will increase coverage by 1%.
The diff coverage is 62%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +1%     
=====================================
  Files          31     31           
  Lines         399    416   +17     
  Branches       95     89    -6     
=====================================
+ Hits          233    248   +15     
- Misses        128    137    +9     
+ Partials       38     31    -7

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
...e/LayoutRenderers/AspNetRequestReferrerRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...7c6d88e. Read the comment docs.

codecov · 2018-09-18T19:59:25Z

Codecov Report

Merging #314 into master will increase coverage by 1%.
The diff coverage is 62%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +1%     
=====================================
  Files          31     31           
  Lines         399    416   +17     
  Branches       95     89    -6     
=====================================
+ Hits          233    248   +15     
- Misses        128    137    +9     
+ Partials       38     31    -7

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
...e/LayoutRenderers/AspNetRequestReferrerRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...a7df74a. Read the comment docs.

codecov · 2018-09-18T20:06:31Z

Codecov Report

Merging #314 into master will increase coverage by 1%.
The diff coverage is 62%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +1%     
=====================================
  Files          31     31           
  Lines         399    416   +17     
  Branches       95     89    -6     
=====================================
+ Hits          233    248   +15     
- Misses        128    137    +9     
+ Partials       38     31    -7

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
...e/LayoutRenderers/AspNetRequestReferrerRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...86b0be4. Read the comment docs.

codecov · 2018-09-18T20:09:06Z

Codecov Report

Merging #314 into master will increase coverage by 1%.
The diff coverage is 62%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +1%     
=====================================
  Files          31     31           
  Lines         399    416   +17     
  Branches       95     89    -6     
=====================================
+ Hits          233    248   +15     
- Misses        128    137    +9     
+ Partials       38     31    -7

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
...e/LayoutRenderers/AspNetRequestReferrerRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...5e3ed80. Read the comment docs.

codecov · 2018-09-18T20:11:08Z

Codecov Report

Merging #314 into master will increase coverage by 2%.
The diff coverage is 65%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +2%     
=====================================
  Files          31     31           
  Lines         399    422   +23     
  Branches       95     90    -5     
=====================================
+ Hits          233    253   +20     
- Misses        128    137    +9     
+ Partials       38     32    -6

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
...e/LayoutRenderers/AspNetRequestReferrerRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...5e3ed80. Read the comment docs.

codecov · 2018-09-18T20:13:12Z

Codecov Report

Merging #314 into master will increase coverage by 2%.
The diff coverage is 65%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +2%     
=====================================
  Files          31     31           
  Lines         399    422   +23     
  Branches       95     90    -5     
=====================================
+ Hits          233    253   +20     
- Misses        128    137    +9     
+ Partials       38     32    -6

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
...e/LayoutRenderers/AspNetRequestReferrerRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...5e3ed80. Read the comment docs.

codecov · 2018-09-18T20:15:37Z

Codecov Report

Merging #314 into master will increase coverage by 2%.
The diff coverage is 66%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    60%   +2%     
=====================================
  Files          31     31           
  Lines         399    426   +27     
  Branches       95     91    -4     
=====================================
+ Hits          233    256   +23     
- Misses        128    137    +9     
+ Partials       38     33    -5

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs	`86% <100%> (ø)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`63% <50%> (+5%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`57% <50%> (+7%)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`83% <50%> (+1%)`	⬆️
...e/LayoutRenderers/AspNetRequestReferrerRenderer.cs	`57% <50%> (+7%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...5e3ed80. Read the comment docs.

codecov · 2018-09-18T20:17:53Z

Codecov Report

Merging #314 into master will increase coverage by 3%.
The diff coverage is 72%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
+ Coverage      58%    61%   +3%     
=====================================
  Files          31     31           
  Lines         399    419   +20     
  Branches       95     90    -5     
=====================================
+ Hits          233    256   +23     
- Misses        128    130    +2     
+ Partials       38     33    -5

Impacted Files	Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs	`0% <ø> (ø)`	⬆️
...LayoutRenderers/AspNetRequestHostLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...nderers/AspNetUserIsAuthenticatedLayoutRenderer.cs	`0% <0%> (ø)`	⬆️
...enderers/AspNetRequestQueryStringLayoutRenderer.cs	`78% <100%> (+4%)`	⬆️
...pNetCore/LayoutRenderers/AspNetRequestuseragent.cs	`71% <100%> (+14%)`	⬆️
...LayoutRenderers/AspNetRequestHttpMethodRenderer.cs	`67% <100%> (+17%)`	⬆️
...e/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs	`83% <100%> (+3%)`	⬆️
NLog.Web.AspNetCore/DefaultHttpContextAccessor.cs	`100% <100%> (ø)`	⬆️
...etCore/LayoutRenderers/AspNetRequestUrlRenderer.cs	`86% <100%> (+5%)`	⬆️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs	`88% <100%> (+4%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0282...aede302. Read the comment docs.

304NotModified · 2018-09-19T19:42:15Z

NLog.Web.AspNetCore/LayoutRenderers/AspNetRequestQueryStringLayoutRenderer.cs

            if (httpRequest == null)
+            {
+                Common.InternalLogger.Debug("aspnet-request-querystring - HttpContext Request is null");


this is now heavily duplicated. Can't be do this in the base class?

I guess it should be possible. But I actually like to write the name of the layout-renderer. So the message is not the same. But I would also like that one only had one debug-alert for a single logevent. Right now one will get a debug-message for every triggered layout-renderer. The same problem with duplicate internal-logmessage happens when no active httpcontext.

I can live with the duplicate message, but not really with the duplicate code ;)

Would it be okay if I just remove the debug-messages then. Because I find it difficult to modify these layoutrenderers without it being breaking interface changes.

And they are gone :)

304NotModified · 2018-09-19T19:43:18Z

What happend - codecov report DDOS?

snakefoot · 2018-09-19T19:44:12Z

What happend - codecov report DDOS?

No idea. Maybe it was super sensitive while I was working on this PR :)

…een checked)

304NotModified

Thanks!

snakefoot force-pushed the master branch from b7a1482 to 44e318f Compare September 16, 2018 15:18

304NotModified self-requested a review September 17, 2018 11:37

304NotModified self-assigned this Sep 17, 2018

snakefoot force-pushed the master branch from 44e318f to 8de37e5 Compare September 18, 2018 19:30

snakefoot force-pushed the master branch from 8de37e5 to ffa332e Compare September 18, 2018 19:34

snakefoot force-pushed the master branch from ffa332e to 885c38b Compare September 18, 2018 19:42

snakefoot force-pushed the master branch from 885c38b to 7c6d88e Compare September 18, 2018 19:44

snakefoot force-pushed the master branch from 7c6d88e to a7df74a Compare September 18, 2018 19:59

snakefoot force-pushed the master branch from a7df74a to 86b0be4 Compare September 18, 2018 20:06

snakefoot force-pushed the master branch from 86b0be4 to 5e3ed80 Compare September 18, 2018 20:09

304NotModified requested changes Sep 19, 2018

View reviewed changes

snakefoot force-pushed the master branch from 5e3ed80 to 37847f7 Compare September 19, 2018 20:50

Skip null-check of HttpContextAccessor.HttpContext in DoAppend (Has b…

aede302

…een checked)

snakefoot force-pushed the master branch from 37847f7 to aede302 Compare September 19, 2018 21:01

304NotModified approved these changes Sep 19, 2018

View reviewed changes

304NotModified changed the title ~~Skip null-check of HttpContextAccessor.HttpContext in DoAppend~~ Better missing httpcontext reporting & Skip null-check of HttpContextAccessor.HttpContext in DoAppend Sep 19, 2018

304NotModified added enhancement ASP.NET Core 1 ASP.NET 4 ASP.NET MVC Classic labels Sep 19, 2018

304NotModified added this to the NLog.Web + NLog.Web.AspNetCore 4.7 milestone Sep 19, 2018

304NotModified merged commit c928e2b into NLog:master Sep 19, 2018

snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 1 labels Jan 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better missing httpcontext reporting & Skip null-check of HttpContextAccessor.HttpContext in DoAppend #314

Better missing httpcontext reporting & Skip null-check of HttpContextAccessor.HttpContext in DoAppend #314

snakefoot commented Sep 16, 2018

snakefoot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

codecov bot commented Sep 18, 2018 •

edited

304NotModified Sep 19, 2018

snakefoot Sep 19, 2018 •

edited

304NotModified Sep 19, 2018

snakefoot Sep 19, 2018

snakefoot Sep 19, 2018

304NotModified commented Sep 19, 2018 •

edited

snakefoot commented Sep 19, 2018 •

edited

304NotModified left a comment

Better missing httpcontext reporting & Skip null-check of HttpContextAccessor.HttpContext in DoAppend #314

Better missing httpcontext reporting & Skip null-check of HttpContextAccessor.HttpContext in DoAppend #314

Conversation

snakefoot commented Sep 16, 2018

snakefoot commented Sep 18, 2018

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018 • edited

Codecov Report

304NotModified Sep 19, 2018

Choose a reason for hiding this comment

snakefoot Sep 19, 2018 • edited

Choose a reason for hiding this comment

304NotModified Sep 19, 2018

Choose a reason for hiding this comment

snakefoot Sep 19, 2018

Choose a reason for hiding this comment

snakefoot Sep 19, 2018

Choose a reason for hiding this comment

304NotModified commented Sep 19, 2018 • edited

snakefoot commented Sep 19, 2018 • edited

304NotModified left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 18, 2018 •

edited

snakefoot Sep 19, 2018 •

edited

304NotModified commented Sep 19, 2018 •

edited

snakefoot commented Sep 19, 2018 •

edited