Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ${aspnet-request-headers} for rendering headers #473

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Added ${aspnet-request-headers} for rendering headers #473

merged 3 commits into from
Sep 20, 2019

Conversation

ThomasArdal
Copy link
Contributor

@ThomasArdal ThomasArdal commented Sep 19, 2019 •
edited by 304NotModified

fixes #355

@304NotModified
Copy link
Member

Thanks for the PR! I'm currently on holiday but will try to check this soon :)

@ThomasArdal
Copy link
Contributor Author

holiday

@snakefoot
Copy link
Contributor

snakefoot commented Sep 19, 2019 •
edited

@ThomasArdal Maybe take a look at #472, and incorporate the ability to Exclude header-keys (Maybe add standard unwanted header-keys by default).

Also notice the optimization, where ToList() is skipped when ASP_NET_CORE.

@snakefoot
Copy link
Contributor

@ThomasArdal Looks great. Approved by me.

@304NotModified 304NotModified merged commit fed8ed0 into NLog:dev Sep 20, 2019
@304NotModified
Copy link
Member

Thanks!!

@304NotModified
Copy link
Member

@ThomasArdal could you please help us in create the wiki page and adding it to https://nlog-project.org/config? (add it to https://github.com/NLog/NLog.github.io/blob/master/config/layout-renderers.json)

@304NotModified 304NotModified changed the title Added ASP.NET + ASP.NET Core layout renderer for rendering headers Added ${aspnet-request-headers} for rendering headers Oct 11, 2019
@304NotModified
Copy link
Member

we need docs for this, related NLog/NLog.github.io#129

@304NotModified 304NotModified mentioned this pull request Oct 11, 2019
Closed
@snakefoot
Copy link
Contributor

@304NotModified Created Wiki-page:

https://github.com/NLog/NLog/wiki/AspNetRequest-Headers-Layout-Renderer

@304NotModified
Copy link
Member

thanks, it's now also on nlog-project.org :)

(fixed by NLog/NLog.github.io#132)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified left review comments

Assignees
No one assigned
Labels
docs done docs feature size/L
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

Add ${aspnet-request-headers}
3 participants
@ThomasArdal @304NotModified @snakefoot