Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${Assembly-version} working for asp.net (core) #66

Merged
merged 4 commits into from May 13, 2017

Conversation

304NotModified
Copy link
Member

fixes #46

@304NotModified
Copy link
Member Author

works locally...

@codecov
Copy link

codecov bot commented May 13, 2017

Codecov Report

Merging #66 into master will decrease coverage by 2.28%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage    60.9%   58.62%   -2.29%     
==========================================
  Files          27       28       +1     
  Lines         353      377      +24     
  Branches       83       90       +7     
==========================================
+ Hits          215      221       +6     
- Misses        103      119      +16     
- Partials       35       37       +2
Impacted Files Coverage Δ
...e/LayoutRenderers/AssemblyVersionLayoutRenderer.cs 25% <25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b001e2...ba67f51. Read the comment docs.

@codecov
Copy link

codecov bot commented May 13, 2017

Codecov Report

Merging #66 into master will decrease coverage by 3.72%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage    60.9%   57.18%   -3.73%     
==========================================
  Files          27       29       +2     
  Lines         353      383      +30     
  Branches       83       92       +9     
==========================================
+ Hits          215      219       +4     
- Misses        103      125      +22     
- Partials       35       39       +4
Impacted Files Coverage Δ
...e/LayoutRenderers/AssemblyVersionLayoutRenderer.cs 25% <25%> (ø)
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 80.76% <0%> (-3.85%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 95.12% <0%> (-2.44%) ⬇️
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b001e2...c31897c. Read the comment docs.

@304NotModified 304NotModified changed the title [WIP] Assembly version aspnet ${Assembly version} working for asp.net (core) May 13, 2017
@304NotModified 304NotModified changed the title ${Assembly version} working for asp.net (core) ${Assembly-version} working for asp.net (core) May 13, 2017
@304NotModified 304NotModified merged commit 3494b0c into master May 13, 2017
@304NotModified 304NotModified deleted the assembly-version-aspnet branch May 13, 2017 19:27
@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 1 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET Core ASP.NET Core - all versions ASP.NET 4 ASP.NET MVC Classic enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

${assembly-version} returns "Could not find entry assembly" in ASP.NET
2 participants