ASP.NET Response Cookie Layout Renderer

[bakgerman]

Add Response Cookie Layout Render based on request Cookie layout render.
But, this has important difference for ASP.NET Core version.
We need to install Microsoft.AspNetCore.Http.Extensions NuGet package version 2.1.x other wise the cookie for response can only be Append() or Delete().
So, when we install this NuGet, it installs extension methods for Session named GetString() and GetInt32().
So these 2 method need to be delete from HttpContextExtensions.cs otherwise compiler gives 2 ambiguous call errors.
After these are deleted, re-executing all the unit test still give successful results.

[codecov-commenter]

Codecov Report

Merging #789 (c86d101) into master (55a7fca) will increase coverage by 5%.
The diff coverage is 88%.

@@          Coverage Diff           @@
##           master   #789    +/-   ##
======================================
+ Coverage      63%    68%    +5%     
======================================
  Files          48     59    +11     
  Lines         790   1010   +220     
  Branches      196    251    +55     
======================================
+ Hits          498    684   +186     
- Misses        223    225     +2     
- Partials       69    101    +32     

Impacted Files	Coverage Δ
...outRenderers/AspNetResponseCookieLayoutRenderer.cs	88% <88%> (ø)
...utRenderers/AspNetRequestDurationLayoutRenderer.cs	58% <0%> (-7%)	⬇️
...Renderers/AspNetRequestPostedBodyLayoutRenderer.cs	85% <0%> (ø)
...enderers/AspNetRequestIsWebSocketLayoutRenderer.cs	100% <0%> (ø)
...utRenderers/AspNetResponseHeadersLayoutRenderer.cs	78% <0%> (ø)
...equestWebSocketRequestedProtocolsLayoutRenderer.cs	78% <0%> (ø)
...Renderers/AspNetRequestRemotePortLayoutRenderer.cs	67% <0%> (ø)
...tRenderers/AspNetRequestLocalPortLayoutRenderer.cs	67% <0%> (ø)
...nderers/AspNetResponseContentTypeLayoutRenderer.cs	71% <0%> (ø)
src/NLog.Web/NLogRequestPostedBodyModule.cs	69% <0%> (ø)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a7fca...c86d101. Read the comment docs.

[bakgerman]

The 3 code smell come from the code I copy from RequestCookieLayoutRenderer.
I had to write GetCookies method only for ASP_NET_CORE2, since this is older version without SetCookie property on IHeaderDictionary interface.
The NuGet package changes are all rolled back to original.

[snakefoot]

Will this not work for ASP_NET_CORE (net5 + netcoreapp3 + netstandard2), and will be faster than GetTypedHeaders() ?

        protected IList<SetCookieHeaderValue> GetCookies(HttpResponse response)
        {
            var queryResults = response.Headers[HeaderNames.SetCookie];
            if (queryResults.Count > 0 && SetCookieHeaderValue.TryParseList(queryResults, out var result))
                return result;
            else 
                return Array.Empty<SetCookieHeaderValue>();
        }

[bakgerman]

Added back Microsoft.AspNetCore.http.Extensions NuGet Package, but ONLY for ASP_NET_CORE2 case.
This is a special case where the HttpContext.Response.Headers class is different from the ASP_NET_CORE3 case.
Copying the 1 line of the extension method required into our code failed since this uses a class that is not provided in ASP_NET_CORE2, so we need the whole NuGet package. It is understood that the ASP_NET_CORE2 case has additional NuGets over ASP_NET_CORE3 case, so this should add the NuGet package ONLY where necessary and not in all cases.

[bakgerman]

Will this not work for ASP_NET_CORE (net5 + netcoreapp3 + netstandard2), and will be faster than GetTypedHeaders() ?

        protected IList<SetCookieHeaderValue> GetCookies(HttpResponse response)
        {
            var queryResults = response.Headers[HeaderNames.SetCookie];
            if (queryResults.Count > 0 && SetCookieHeaderValue.TryParseList(queryResults, out var result))
                return result;
            else 
                return Array.Empty<SetCookieHeaderValue>();
        }

oh sorry I did not see, i will try that. Did not realize there is parselist method. I was just doing parse where I split the string by comma, but that is brittle.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

92.6% Coverage
0.0% Duplication

[snakefoot]

Thanks again for completing all my comments. And great work with the test-coverage.

[snakefoot]

Created wiki page: https://github.com/NLog/NLog/wiki/AspNet-Response-Cookie-Layout-Renderer