Tls Handshake Layout Render

[bakgerman]

Add a single layout render, with an enum to specify which property to render, with unit tests.
Modelled upon ProcessInfoLayoutRenderer.
Hopefully better than 7 separate layout renderers.

[snakefoot]

Thank you for the pull-request and the unit-tests.

And you have been missing this layout-renderer while developing ASP.NET Core applications?

[bakgerman]

Thank you for the pull-request and the unit-tests.

And you have been missing this layout-renderer while developing ASP.NET Core applications?

Basically I had to prove the details of the TLS being used to the security team, I don't know why they think the application can affect the chosen handshake. But I have to prove the application innocent.

[bakgerman]

I examined other interfaces available in the HttpContext FeatureCollection and did some more LayoutRenders, but I am not sure if they are good for NLog or not. I found the following, but these only work for ASP_NET_CORE3 case in NLog.Web:

Http/2 request trailer
Http/2 response trailer
DoNotTrack
OAuth bearer token
http compression mode
Server Variables - server variables are available in ASP.NET Core, I had to use this to log AppPool of my application to prove they assign my application to wrong app pool. That one might be good.

[snakefoot]

Again. I'm an ignorant to ASP.NET Core applications, so my observations might not be true:

• Http/2 request trailer - These are probably part of the request-body, so requires middleware.
• Http/2 response trailer - These are probably part of the response-body, so requires middleware.
• DoNotTrack - Sounds good.
• http compression mode - Sounds good.
• Server Variables - server variables are available in ASP.NET Core - Sounds good.
• OAuth bearer token - Might be useful to diagnose authentication-issue.

[bakgerman]

I see, we agree in our opinion. :)
I thought a lot of it was useful only for internal Microsoft developer or for middle ware developer.

I am go on holiday today for a week but I will finish the unit tests and submit a pull request for the ones we think are useful for NLog.

Regards,
Burak

[snakefoot]

Created wiki-page: https://github.com/NLog/NLog/wiki/AspNet-Request-TLS-Handshake-Layout-Renderer

[codecov-commenter]

Codecov Report

Merging #802 (840483f) into master (61f8567) will increase coverage by 1%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #802   +/-   ##
=====================================
+ Coverage      68%    70%   +1%     
=====================================
  Files          61     62    +1     
  Lines        1142   1146    +4     
  Branches      287    289    +2     
=====================================
+ Hits          779    797   +18     
+ Misses        239    225   -14     
  Partials      124    124           

Impacted Files	Coverage Δ
src/Shared/Internal/HttpContextExtensions.cs	68% <ø> (+14%)	⬆️
...enderers/AspNetRequestIsWebSocketLayoutRenderer.cs	100% <0%> (ø)
...equestWebSocketRequestedProtocolsLayoutRenderer.cs	78% <0%> (ø)
...enderers/AspNetResponseHasStartedLayoutRenderer.cs	100% <0%> (ø)
...utRenderers/AspNetRequestDurationLayoutRenderer.cs	64% <0%> (+7%)	⬆️
...rs/AspNetRequestClientCertificateLayoutRenderer.cs	57% <0%> (+7%)	⬆️
...ared/LayoutRenderers/AspNetRequestContentLength.cs	100% <0%> (+29%)	⬆️
...enderers/AspNetRequestContentTypeLayoutRenderer.cs	71% <0%> (+71%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f8567...840483f. Read the comment docs.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[snakefoot]

Thank you again for another nice contribution.