Add aspnet-request-servervariable and aspnet-request-item layout renders

[bakgerman]

Most of the server variables can be done with other layout render, but some like APP_POOL_ID are only in server variable collection. See https://docs.microsoft.com/en-us/previous-versions/iis/6.0-sdk/ms524602(v=vs.90)

(I change the title of the pull request to match the actual commit now).

[codecov-commenter]

Codecov Report

Merging #811 (5f994cf) into master (a35f036) will decrease coverage by 0%.
The diff coverage is 54%.

❗ Current head 5f994cf differs from pull request most recent head cfc38c8. Consider uploading reports for the commit cfc38c8 to get more accurate results

@@          Coverage Diff          @@
##           master   #811   +/-   ##
=====================================
- Coverage      70%    69%   -0%     
=====================================
  Files          62     64    +2     
  Lines        1146   1159   +13     
  Branches      289    294    +5     
=====================================
+ Hits          797    801    +4     
- Misses        225    231    +6     
- Partials      124    127    +3     

Impacted Files	Coverage Δ
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs	97% <ø> (ø)
...utRenderers/AspNetHttpContextItemLayoutRenderer.cs	50% <50%> (ø)
...erers/AspNetRequestServerVariableLayoutRenderer.cs	60% <60%> (ø)
...utRenderers/AspNetRequestDurationLayoutRenderer.cs	58% <0%> (-7%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a35f036...cfc38c8. Read the comment docs.

[snakefoot]

Maybe introduce a dedicated layoutrenderer. Ex. ${aspnet-request-servervariable} to follow the guidance from the wiki

[bakgerman]

Yes I see, that makes sense. I will do that.

[bakgerman]

Added aspnet-request-servervariable and also added aspnet-request-item since I did not see that one either.
Should I make the single parameter for both of these [RequiredParameter]?

[bakgerman]

Fixing a unit test

[bakgerman]

nuget.org has decided that github.com makes too many requests. This is the error from Appveyor build:

Retrying 'FindPackagesByIdAsync' for source 'https://api.nuget.org/v3-flatcontainer/microsoft.sourcelink.common/index.json'.
Response status code does not indicate success: 429 (Too Many Requests).
Failed to download package 'Microsoft.Build.Tasks.Git.1.1.1' from 'https://api.nuget.org/v3-flatcontainer/microsoft.build.tasks.git/1.1.1/microsoft.build.tasks.git.1.1.1.nupkg'.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

94.4% Coverage
0.0% Duplication

[snakefoot]

Thank you again for being patient with me, and resolving all my nitpicks.

[snakefoot]

Hrmm just discovered this baby AspNetItemValueLayoutRenderer. Guess something must be merged.

[bakgerman]

Thank you for being patient with me also.

[bakgerman]

I did not see that AspNetItemValueLayoutRenderer either. (That is where the proper naming helps).

[snakefoot]

Created #814

[snakefoot]

I did not see that AspNetItemValueLayoutRenderer either. (That is where the proper naming helps).

Yes naming is a hard dicipline. Always a good idea to ask a friend.

[snakefoot]

Created wiki-page: https://github.com/NLog/NLog/wiki/AspNet-Request-ServerVariable-Layout-Renderer