-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added several layout renders for NLog.Web.AspNetCore #815
Added several layout renders for NLog.Web.AspNetCore #815
Conversation
bakgerman
commented
Jul 8, 2022
•
edited
edited
- Do Not Track
- TLS Provider and Referrer Tokens
-
- This finishes the TLS renders since we already do TLS Handshake and Client Certificate. I could not find Server Certificate anywhere in HttpContext
- Compression Mode
- Request Trailers and Response Trailers, we did think at first this was for middleware only but after I read about it the application code can set these for http/1.1 chunk and for http/2
- SignalR renders
-
- http transport type
-
- is 2 way communication capable
-
- is connection kept alive
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
=====================================
- Coverage 70% 69% -0%
=====================================
Files 62 63 +1
Lines 1146 1158 +12
Branches 289 290 +1
=====================================
+ Hits 797 802 +5
- Misses 225 227 +2
- Partials 124 129 +5
Continue to review full report at Codecov.
|
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionHttpTransportTypeLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionInherentKeepAliveLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionHttpTransportTypeLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionInherentKeepAliveLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetRequestTrailersLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetRequestTrailersLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetRequestTwoWayCapableLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetRequestTwoWayCapableLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetResponseHttpsCompressionLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetResponseHttpsCompressionLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetResponseTrailersLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetTlsTokenBindingLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetResponseTrailersLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetTlsTokenBindingLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetTrackingConsentLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetTrackingConsentLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetTlsTokenBindingLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetTrackingConsentLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetTlsTokenBindingLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetRequestIsUpgradableCapableLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetRequestTrackingConsentLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
...NLog.Web.AspNetCore/LayoutRenderers/AspNetRequestStreamBidirectionalCapableLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetRequestInherentKeepAliveLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
Thank you snakefoot |
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetRequestHttpTransportTypeLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Thank you again for a nice contribution. With unit-tests that provides 100 pct code-coverage. Excellent job. |
@bakgerman I was thinking to release NLog.Web.AspNetCore v5.1.0, unless you are already preparing more contributions? |
I think that sounds great. |