Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added several layout renders for NLog.Web.AspNetCore #815

Merged
merged 10 commits into from
Jul 16, 2022

Conversation

bakgerman
Copy link
Contributor

@bakgerman bakgerman commented Jul 8, 2022

  • Do Not Track
  • TLS Provider and Referrer Tokens
    • This finishes the TLS renders since we already do TLS Handshake and Client Certificate. I could not find Server Certificate anywhere in HttpContext
  • Compression Mode
  • Request Trailers and Response Trailers, we did think at first this was for middleware only but after I read about it the application code can set these for http/1.1 chunk and for http/2
  • SignalR renders
    • http transport type
    • is 2 way communication capable
    • is connection kept alive

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #815 (c2efa11) into master (7f0e167) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #815   +/-   ##
=====================================
- Coverage      70%    69%   -0%     
=====================================
  Files          62     63    +1     
  Lines        1146   1158   +12     
  Branches      289    290    +1     
=====================================
+ Hits          797    802    +5     
- Misses        225    227    +2     
- Partials      124    129    +5     
Impacted Files Coverage Δ
...tRenderers/AspNetApplicationValueLayoutRenderer.cs 69% <0%> (-13%) ⬇️
...ayoutRenderers/AspNetSessionValueLayoutRenderer.cs 76% <0%> (-10%) ⬇️
...utRenderers/AspNetRequestDurationLayoutRenderer.cs 62% <0%> (-2%) ⬇️
...erers/AspNetRequestServerVariableLayoutRenderer.cs 60% <0%> (ø)
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs 97% <0%> (+<1%) ⬆️
...d/LayoutRenderers/AspNetItemValueLayoutRenderer.cs 93% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0e167...c2efa11. Read the comment docs.

@snakefoot snakefoot modified the milestone: 5.1.0 Jul 14, 2022
@bakgerman
Copy link
Contributor Author

Thank you snakefoot

@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit b57d70a into NLog:master Jul 16, 2022
@snakefoot snakefoot changed the title Renderers from HttpContext Features Collection Added several layout renders for NLog.Web.AspNetCore Jul 16, 2022
@snakefoot
Copy link
Contributor

Thank you again for a nice contribution. With unit-tests that provides 100 pct code-coverage. Excellent job.

@bakgerman bakgerman deleted the httpcontext-features-renderers branch July 17, 2022 01:33
@snakefoot
Copy link
Contributor

@bakgerman I was thinking to release NLog.Web.AspNetCore v5.1.0, unless you are already preparing more contributions?

@bakgerman
Copy link
Contributor Author

I think that sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants