Improved re-entrancy Scope Lock for Session Value Layout Render

[bakgerman]

Also fix spelling errors and remove unused using statements. Resolves #847

[codecov-commenter]

Codecov Report

Merging #850 (7a52795) into master (499850e) will decrease coverage by 0%.
The diff coverage is 47%.

@@          Coverage Diff          @@
##           master   #850   +/-   ##
=====================================
- Coverage      69%    69%   -0%     
=====================================
  Files          63     65    +2     
  Lines        1157   1214   +57     
  Branches      286    309   +23     
=====================================
+ Hits          804    843   +39     
+ Misses        229    226    -3     
- Partials      124    145   +21     

Impacted Files	Coverage Δ
...ayoutRenderers/AspNetSessionValueLayoutRenderer.cs	54% <36%> (-23%)	⬇️
src/Shared/Internal/ReEntrantScopeLock.cs	54% <54%> (ø)
...utRenderers/AspNetRequestDurationLayoutRenderer.cs	58% <0%> (-7%)	⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs	86% <0%> (-1%)	⬇️
src/NLog.Web/Internal/HostEnvironment.cs	0% <0%> (ø)
...Renderers/AspNetRequestPostedBodyLayoutRenderer.cs	86% <0%> (+1%)	⬆️
...LayoutRenderers/AspNetAppBasePathLayoutRenderer.cs	53% <0%> (+53%)	⬆️
...d/LayoutRenderers/IISInstanceNameLayoutRenderer.cs	67% <0%> (+67%)	⬆️
...LayoutRenderers/AspNetWebRootPathLayoutRenderer.cs	67% <0%> (+67%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[snakefoot]

Could the Re-Entrant logic be put in an IDiposable-struct, that implements IDisposable. Where struct-constructor setup the blocker, and the dispose-method removes the blocker.

Then the IDiposable-struct can used in a using-statement to protect the lookup.

[bakgerman]

Could the Re-Entrant logic be put in an IDiposable-struct, that implements IDisposable. Where struct-constructor setup the blocker, and the dispose-method removes the blocker.

Then the IDiposable-struct can used in a using-statement to protect the lookup.

That sounds like a great idea. We will do that.

[snakefoot]

Yes see that TryGetLock must be changed to static method that receives httpContext as input parameter. Can this be done?

[bakgerman]

changed as requested. I did not know that about struct, so I learned something new.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

79.4% Coverage
0.0% Duplication

[snakefoot]

@bakgerman I think it looks great now. Do you have any more changes that you want to make ?

[bakgerman]

@bakgerman I think it looks great now. Do you have any more changes that you want to make ?

No, I'm done with this pull if you agree

[snakefoot]

Once again thank you for being patient with all my nit-picking.