Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspnet-request-url - Support properties-option instead of booleans #856

Merged
merged 7 commits into from
Aug 16, 2022

Conversation

bakgerman
Copy link
Contributor

@bakgerman bakgerman commented Aug 15, 2022

Resolves #855

Burak Akgerman added 2 commits August 15, 2022 09:55
…ke in the comments. removed unused using statements. Still need to fix the comments to use the flags enum instead of the boolean properties.
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #856 (49059c9) into master (499850e) will decrease coverage by 0%.
The diff coverage is 79%.

@@          Coverage Diff          @@
##           master   #856   +/-   ##
=====================================
- Coverage      69%    69%   -0%     
=====================================
  Files          63     65    +2     
  Lines        1157   1209   +52     
  Branches      286    307   +21     
=====================================
+ Hits          804    840   +36     
- Misses        229    230    +1     
- Partials      124    139   +15     
Impacted Files Coverage Δ
...Shared/LayoutRenderers/AspNetRequestUrlRenderer.cs 79% <79%> (-8%) ⬇️
...ayoutRenderers/AspNetSessionValueLayoutRenderer.cs 62% <0%> (-15%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 86% <0%> (-1%) ⬇️
...d/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs 100% <0%> (ø)
src/Shared/Internal/ReEntrantScopeLock.cs 0% <0%> (ø)
src/NLog.Web/Internal/HostEnvironment.cs 0% <0%> (ø)
...Renderers/AspNetRequestPostedBodyLayoutRenderer.cs 86% <0%> (+1%) ⬆️
...LayoutRenderers/AspNetAppBasePathLayoutRenderer.cs 53% <0%> (+53%) ⬆️
...d/LayoutRenderers/IISInstanceNameLayoutRenderer.cs 67% <0%> (+67%) ⬆️
...LayoutRenderers/AspNetWebRootPathLayoutRenderer.cs 67% <0%> (+67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

82.1% 82.1% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@snakefoot snakefoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it looks great now. Thank you again for this fine contribution.

…timized the using statements for the unit test for url renderer.
@snakefoot snakefoot merged commit 223946f into NLog:master Aug 16, 2022
@snakefoot snakefoot changed the title aspnet-request-url - change to property-enum instead of booleans aspnet-request-url - Support properties-option instead of booleans Aug 16, 2022
@snakefoot
Copy link
Contributor

@snakefoot snakefoot added this to the 5.1.1 milestone Aug 16, 2022
@bakgerman bakgerman deleted the url-render branch August 19, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aspnet-request-url - change to property-enum instead of booleans
3 participants