Apply ArgumentNullException.ThrowIfNull to NLog source-code

[bakgerman]

I try to follow your example exactly as you say.

I had to make if statement for this attribute

#if NETCOREAPP3_1_OR_GREATER
[CallerArgumentExpression("argument")]
#endif

since it is not in NET 461 or CORE 2.x, but other than that I did not find any difficulty.

[codecov-commenter]

Codecov Report

Base: 70% // Head: 69% // Decreases project coverage by -1% ⚠️

Coverage data is based on head (d8e566b) compared to base (0176c44).
Patch has no changes to coverable lines.

Additional details and impacted files

@@          Coverage Diff          @@
##           master   #889   +/-   ##
=====================================
- Coverage      70%    69%   -1%     
=====================================
  Files          65     65           
  Lines        1218   1230   +12     
  Branches      308    316    +8     
=====================================
- Hits          850    849    -1     
- Misses        229    240   +11     
- Partials      139    141    +2     

Impacted Files	Coverage Δ
.../Shared/LayoutRenderers/AspNetMvcActionRenderer.cs	67% <0%> (-13%)	⬇️
...red/LayoutRenderers/AspNetMvcControllerRenderer.cs	67% <0%> (-13%)	⬇️
...utRenderers/AspNetRequestDurationLayoutRenderer.cs	56% <0%> (-9%)	⬇️
...tRenderers/AspNetRequestRouteParametersRenderer.cs	17% <0%> (+7%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[snakefoot]

Would it be possible to apply the solution found here: NLog/NLog#5068 ? (Explicit define CallerArgumentExpressionAttribute when not part of target-platform)

Would be nice to get rid of these lines (Maybe always use Guard.ThrowIfNull):

#if NET6_0_OR_GREATER
using ArgumentNullException = System.ArgumentNullException;
#else
using ArgumentNullException = NLog.Web.Internal.ArgumentNullException;
#endif

[bakgerman]

Should now be as requested, thank you for the reference into NLog commit.

[bakgerman]

Added unit tests for CallerArgumentExpressionAttribute class

[snakefoot]

Could you make an unit-test that verifies that UseNLog() throws a valid ArgumentNullException with expected ParamName-property ?

[bakgerman]

unit test added as requested

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

87.5% Coverage
0.0% Duplication

[snakefoot]

Looks like the internal CallerArgumentExpressionAttribute is working, since .NET Framework v4.6.1 also works.

Thank you for this nice pull-request and the unit-tests.