Removed platforms when supporting all platforms #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
platform-cleanup
branch
from
e3c6f18
to
297bd34
Compare
snakefoot
force-pushed
the
platform-cleanup
branch
from
297bd34
to
76bed2c
Compare
|
Should we merge this after NLog 5.0 RTM? |
|
Would like to have this PR merged now to simplify the platform-list. This will allow me to prepare a PullRequest with the actual chances for NLog 5.0 RTM |
I think we should do that only for NLog 5? Doubting how to handle the NLog 4 docs |
|
Think all users expect that Dotnet support means Xamarin support. And with NLog v5 then default-values have been optimized for Xamarin and UWP platforms.
See no need for anything special to separate NLog v4 and v5, besides what is documented in the wiki pages.
|
What do you mean with "Dotnet"? .net standard, .net core, .net 5-6? |
|
All of them. The whole idea with Xamarin is using dotnet. And Microsoft have spent a lot of energy to unify it all with
|
|
@304NotModified Any chance for approval, so able to prepare the next pull-request? |
snakefoot
force-pushed
the
platform-cleanup
branch
from
76bed2c
to
6672ff0
Compare
snakefoot
force-pushed
the
platform-cleanup
branch
from
6672ff0
to
c2f7823
Compare
|
@304NotModified Any chance of this getting merge, so I can start on the documentation-updates for NLog 5.0 release? |
304NotModified
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial step for resolving #182
Already now Target-Wrappers (Ex. AsyncWrapper) that are platform-agnostic does not specify platform-restrictions.
Also removed Xamarin iOS + Xamarin Android + Silverlight + WP8, as replaced by .NET Standard.