-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to VS2017 #1954
Comments
Hi - I can help with this and also with moving to C#6/C#7 in free time |
Hi- Is this already picked up, if not then I can start on it? |
AFAIK this isn't started yet. I dunno if we could use the new csproj format. If we could, then I prefer that. (no need to sync project files then!) Would be great if someone has time for this :) (but please keep the code changes at minimal for now) |
@304NotModified Thanks a lot for getting back to me, as I am totally new to open source and this is going to be my first request can you please guide me how to proceed to this as I can see there are multiple solution files for each .NET framework. |
Silverlight 4, Silverlight 5, WP 8.1 are not supported in VS2017. You need VS2015 to build them. So I suppose we would need separate project files for VS2015 compatible and VS2017 compatible frameworks which sounds rather messy. On the other hand, is there a need to keep support for WP8 and Silverlights? |
@snakefoot were you able to build NLog from VS2017? I tried installing SL4 and SL5 SDKs but they don't seem to work. |
@stil Well I didn't want to ruin my beautiful computer with installing all kind of random stuff, so I just performed trial-on-error using AppVeyor-VS2017-Image. Had to use msbuild instead of dotnet for building, as the dotnet-tool doesn't like other platforms. |
That's strange as dotnet is forwarding the calls to msbuild (see https://stackoverflow.com/a/43455110/201303) Maybe is the dotnet version older. |
@304NotModified Msbuild and dotnet setup different targets-files before being launched (Available SDKs). So even if dotnet launches msbuild, then it has probably setup a different (limited) build configuration environment. |
Good one. |
Maybe move milestone to 4.5 |
thx |
No need to sync to conflicts on CSPROJ!
The text was updated successfully, but these errors were encountered: