Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to VS2017 #1954

Closed
304NotModified opened this issue Feb 12, 2017 · 13 comments
Closed

Move to VS2017 #1954

304NotModified opened this issue Feb 12, 2017 · 13 comments
Milestone

Comments

@304NotModified
Copy link
Member

304NotModified commented Feb 12, 2017

  • Move all SLN files (net45.sln, net40.sln, wp8.sln etc) to one VS2017 SLN
  • remove all unneeded SLN and CSPROJ files.

No need to sync to conflicts on CSPROJ!

@vgotra
Copy link

vgotra commented Apr 5, 2017

Hi - I can help with this and also with moving to C#6/C#7 in free time

@gnagar-dev
Copy link

Hi- Is this already picked up, if not then I can start on it?

@304NotModified
Copy link
Member Author

304NotModified commented Apr 24, 2017

AFAIK this isn't started yet.

I dunno if we could use the new csproj format. If we could, then I prefer that. (no need to sync project files then!)

Would be great if someone has time for this :) (but please keep the code changes at minimal for now)

@gnagar-dev
Copy link

@304NotModified Thanks a lot for getting back to me, as I am totally new to open source and this is going to be my first request can you please guide me how to proceed to this as I can see there are multiple solution files for each .NET framework.

@304NotModified 304NotModified modified the milestones: 4.5, 4.6 May 21, 2017
@stil
Copy link

stil commented Sep 5, 2017

Silverlight 4, Silverlight 5, WP 8.1 are not supported in VS2017. You need VS2015 to build them.

So I suppose we would need separate project files for VS2015 compatible and VS2017 compatible frameworks which sounds rather messy.

On the other hand, is there a need to keep support for WP8 and Silverlights?

@snakefoot
Copy link
Contributor

snakefoot commented Sep 5, 2017

@stil You just need to install the right SDKs, and AppVeyor has apparently done it right. Since the there is now a NLog NuGet-package ready for NetStandard2.0 (together with all the other platforms). See #2263

@stil
Copy link

stil commented Sep 5, 2017

@snakefoot were you able to build NLog from VS2017? I tried installing SL4 and SL5 SDKs but they don't seem to work.

@snakefoot
Copy link
Contributor

snakefoot commented Sep 5, 2017

@stil Well I didn't want to ruin my beautiful computer with installing all kind of random stuff, so I just performed trial-on-error using AppVeyor-VS2017-Image.

Had to use msbuild instead of dotnet for building, as the dotnet-tool doesn't like other platforms.

@304NotModified
Copy link
Member Author

That's strange as dotnet is forwarding the calls to msbuild (see https://stackoverflow.com/a/43455110/201303)

Maybe is the dotnet version older.

@snakefoot
Copy link
Contributor

snakefoot commented Sep 5, 2017

@304NotModified Msbuild and dotnet setup different targets-files before being launched (Available SDKs). So even if dotnet launches msbuild, then it has probably setup a different (limited) build configuration environment.

@304NotModified
Copy link
Member Author

Good one.

@snakefoot
Copy link
Contributor

Maybe move milestone to 4.5

@304NotModified 304NotModified modified the milestones: 4.6, 4.5 Oct 9, 2017
@304NotModified
Copy link
Member Author

thx

@304NotModified 304NotModified modified the milestones: 4.5, 4.5 beta ? Oct 10, 2017
@snakefoot snakefoot modified the milestones: 4.5 beta ?, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants