NLog XSD schema broken

[304NotModified]

Warning Type 'http://www.nlog-project.org/schemas/NLog.xsd:Filter' is not declared, or is not a simple type.

Seems to be broken with NLog 4.6.4 (4.6.3 is OK)

broken with NLog/NLog.github.io@febd452

[304NotModified]

Issue:

  <xs:attribute name="filter" type="Filter">
          <xs:annotation>
            <xs:documentation>Filter. Log events who evaluates to  will be discarded</xs:documentation>
          </xs:annotation>
        </xs:attribute>

inside

  <xs:complexType name="FilteringWrapper">
    <xs:complexContent>
      <xs:extension base="WrapperTargetBase">
        <xs:choice minOccurs="0" maxOccurs="unbounded">
          <xs:element name="name" minOccurs="0" maxOccurs="1" type="xs:string" />
          <xs:element name="condition" minOccurs="0" maxOccurs="1" type="Condition" />
          <xs:element name="filter" minOccurs="0" maxOccurs="1" type="Filter" />
          <xs:element name="optimizeBufferReuse" minOccurs="0" maxOccurs="1" type="xs:boolean" />
        </xs:choice>
        <xs:attribute name="name" type="xs:string">
          <xs:annotation>
            <xs:documentation>Name of the target.</xs:documentation>
          </xs:annotation>
        </xs:attribute>
        <xs:attribute name="condition" type="Condition">
          <xs:annotation>
            <xs:documentation>Condition expression. Log events who meet this condition will be forwarded to the wrapped target.</xs:documentation>
          </xs:annotation>
        </xs:attribute>
        <xs:attribute name="filter" type="Filter">
          <xs:annotation>
            <xs:documentation>Filter. Log events who evaluates to  will be discarded</xs:documentation>
          </xs:annotation>
        </xs:attribute>
        <xs:attribute name="optimizeBufferReuse" type="xs:boolean">
          <xs:annotation>
            <xs:documentation>Target supports reuse of internal buffers, and doesn't have to constantly allocate new buffers Required for legacy NLog-targets, that expects buffers to remain stable after Write-method exit</xs:documentation>
          </xs:annotation>
        </xs:attribute>
      </xs:extension>
    </xs:complexContent>
  </xs:complexType>

[304NotModified]

This is not from the template (NLog/tools/MakeNLogXSD/TemplateXSD.xml)

[304NotModified]

filter isn't an attribute, but not sure why it generated like that

[304NotModified]

  <xs:attribute name="filter" type="Filter">
          <xs:annotation>
            <xs:documentation>Filter. Log events who evaluates to  will be discarded</xs:documentation>
          </xs:annotation>
        </xs:attribute>

needs to be removed, as we have already the child element:

          <xs:element name="filter" minOccurs="0" maxOccurs="1" type="Filter" />

[304NotModified]

found another issue -> #3473

[304NotModified]

quick fixed online by NLog/NLog.github.io@8bdcd92#diff-7a71422add18a6aa259cdf7abd0887d1

[304NotModified]

tools/MakeNLogXSD/XsdFileGenerator.cs of dfd3845 could be the issue

[304NotModified]

[NLogConfigurationIgnorePropertyAttribute] for FilteringTargetWrapper.Filter could be a solution , but not sure what side effects that has (used in ObjectGraphScanner)

[snakefoot]

tools/MakeNLogXSD/XsdFileGenerator.cs of dfd3845 could be the issue

Not super skilled with MakeNLogXSD. But maybe this will improve the output: #3474