New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FilteringTargetWrapper - Fix XSD for Filter-property #3474
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3474 +/- ##
======================================
+ Coverage 81% 81% +<1%
======================================
Files 343 343
Lines 27834 27834
Branches 3766 3766
======================================
+ Hits 22447 22455 +8
+ Misses 4295 4287 -8
Partials 1092 1092 |
That's an easy solution :) But do you think we should have the possibility to set the filter attribute (and also condition?) on the filter wrapper? |
Another option is to hide it |
I'm pretty blank when it comes to crafting XSD, so you are welxome to take over :)
|
Ok, but I mean from the XML (NLog.config, not xsd) for
So functional, not technical. :) |
Eg We have
Does this makes sense?
And then what about
|
Sounds like you are on top of things. If you can hide Filter as attribute, then please do so. |
thanks, I like the idea as failsafe, so added it here: #3475 |
Please don't use NLogConfigurationIgnoreProperty
|
Why not? I tested it, look ok to me |
I'm very confused. You said already that you know that Well updated #3476 with a unit test that will fail, when people adds unwanted attributes to random properties. |
Yes, and afterwards I tested it, including the code paths that are changed... |
But the updated unit-test in #3476 fails when you add that attribute to the Filter-property. Please try. |
You're right. I didn't understand that my change was breaking things. Then my PR is a no-go :) |
No description provided.