ObjectHandle - LifeTime avoid remoting exception: has been disconnected #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2910 +/- ##
=====================================
Coverage ? 80%
=====================================
Files ? 329
Lines ? 24943
Branches ? 3186
=====================================
Hits ? 20041
Misses ? 4029
Partials ? 873 |
snakefoot
force-pushed
the
ObjectHandleLifeTime
branch
6 times, most recently
from
00c0c3b
to
78a9287
Compare
…eption with disconnected or does not exist at the server
snakefoot
force-pushed
the
ObjectHandleLifeTime
branch
from
78a9287
to
b07a445
Compare
304NotModified
approved these changes
Sep 12, 2018
|
👍 thanks! |
|
Should improve performance (Compare to the ToString-hack in NLog/NLog.Extensions.Logging#232), as it can defer the ToString-operation and Type-checking until actually doing AppDomain-transfer. But it is not funny to read articles about remoting and AppDomains. So many cries about pitfalls and dead-ends. |
snakefoot
added a commit
to snakefoot/NLog
that referenced
this pull request
Sep 24, 2018
…eption with disconnected or does not exist at the server (NLog#2910)
snakefoot
added a commit
to snakefoot/NLog
that referenced
this pull request
Nov 4, 2018
…eption with disconnected or does not exist at the server (NLog#2910)
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or does not exist at the server. Followup to #2857
The recommendation of using ObjectHandle from David Fowler was a trap.
Instead perform ToString serialization on-demand when changing AppDomain (Deferring the overhead of remoting until actually AppDomain transfer). Avoid funny business with ObjectHandle lifetime management using the AppDomain-Default-LifeTime. Avoid funny business with returning null in InitializeLifetimeService, and abusing the finalizer queue for cleanup.