LogBuilder - Support Fluent API where message-template is assigned later #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2963 +/- ##
======================================
- Coverage 80% 80% -<1%
======================================
Files 331 331
Lines 25715 25717 +2
Branches 3337 3338 +1
======================================
- Hits 20633 20615 -18
- Misses 4140 4165 +25
+ Partials 942 937 -5 |
snakefoot
force-pushed
the
LogBuilderMessageAfterProperties
branch
3 times, most recently
from
7367a83
to
5ae0b18
Compare
snakefoot
force-pushed
the
LogBuilderMessageAfterProperties
branch
2 times, most recently
from
72d1a21
to
ba184f6
Compare
|
@304NotModified Maybe release NLog 4.5.11 with this bug-fix, since NLog 4.6 is not ready yet. |
|
this is bugfix, isn't? |
Yes it fails to correctly capture the message-template-properties, when assigning message-template after having added custom-properties. |
|
Could you please rebase this on master? Then I could cherry-pick it afterwards to dev. Thanks! |
Only if ver. 4.5.11 also includes #2983 + #2940 + #2937 + #2926 :) Should I make new PullRequest for these on master, since already merged to dev? |
snakefoot
force-pushed
the
LogBuilderMessageAfterProperties
branch
from
ba184f6
to
74eea4a
Compare
This was referenced Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2965, which is also reported here:
https://stackoverflow.com/questions/52819710/nlog-changes-behaviour-depending-on-logger-priority