Refactor filetarget + target to reduce code complexity #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3160 +/- ##
======================================
- Coverage 80% 80% -<1%
======================================
Files 353 353
Lines 27844 27845 +1
Branches 3690 3688 -2
======================================
- Hits 22203 22201 -2
- Misses 4585 4586 +1
- Partials 1056 1058 +2 |
|
Have you used a refactor tool for this? (So no need to review in depth) |
|
FileTarget.cs and Target.cs changes was done by hand. |
304NotModified
changed the title
|
thanks! I think it would be nice if we could move out some methods out of the FileTarget in the future. It's really too large. |
|
Yes the file archive logic would probably be a good candidate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.