${when}, support for RawValue on Inner and Else #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2019
304NotModified
force-pushed
the
whenLayout-irawValue
branch
from
1ffaf36
to
2dfe3b6
Compare
|
@snakefoot I checked your comments in the other PR. Your right. I think I have proper implemented it now. |
snakefoot
reviewed
May 6, 2019
| return false; | ||
| } | ||
|
|
||
| return Inner.TryGetRawValue(logEvent, out value); |
There was a problem hiding this comment.
Could this also work:
value = null;
if (ShouldRenderInner(logEvent))
return Inner?.TryGetRawValue(logEvent, out value) ?? false;
else
return Else?.TryGetRawValue(logEvent, out value) ?? false;There was a problem hiding this comment.
I think it should work, but a bit hard to read. But I see the problem of the verbose/duplicate code. Will create a helper and let's see if it's then better.
There was a problem hiding this comment.
PS: we need a helper
There was a problem hiding this comment.
added helper. Let me know what you think
Codecov Report
@@ Coverage Diff @@
## dev #3373 +/- ##
=====================================
Coverage ? 81%
=====================================
Files ? 344
Lines ? 27607
Branches ? 3713
=====================================
Hits ? 22290
Misses ? 4243
Partials ? 1074 |
304NotModified
added a commit
that referenced
this pull request
May 12, 2019
* ${when}, support for RawValue on Inner and Else
* Added helper
This was referenced May 12, 2019
304NotModified
added a commit
that referenced
this pull request
May 20, 2019
* ${when}, support for RawValue on Inner and Else
* Added helper
304NotModified
added a commit
that referenced
this pull request
May 28, 2019
* ${when}, support for RawValue on Inner and Else
* Added helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3139