Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerformanceCounterLayoutRenderer - Added Layout support for Instance #3579

Merged
merged 1 commit into from Sep 8, 2019
Merged

PerformanceCounterLayoutRenderer - Added Layout support for Instance #3579

merged 1 commit into from Sep 8, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Sep 2, 2019 •
edited

Resolves #3569 and #304 by adding Layout-support for Instance-property

Note merge to master

@snakefoot snakefoot mentioned this pull request Sep 2, 2019
Closed
@snakefoot snakefoot force-pushed the PerformanceLayoutRendererLayout branch from 279f225 to dca4c7f Compare September 2, 2019 17:22
@304NotModified 304NotModified self-assigned this Sep 2, 2019
@304NotModified
Copy link
Member

added merge, also for triggering azure pipelines

304NotModified
304NotModified reviewed Sep 3, 2019
View reviewed changes
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/NLog/LayoutRenderers/PerformanceCounterLayoutRenderer.cs Outdated Show resolved Hide resolved
src/NLog/LayoutRenderers/PerformanceCounterLayoutRenderer.cs Show resolved Hide resolved
src/NLog/LayoutRenderers/PerformanceCounterLayoutRenderer.cs Show resolved Hide resolved
@304NotModified 304NotModified added this to the 4.6.8 milestone Sep 3, 2019
@snakefoot snakefoot force-pushed the PerformanceLayoutRendererLayout branch 3 times, most recently from 7084a5e to a65551f Compare September 4, 2019 20:46
@snakefoot snakefoot force-pushed the PerformanceLayoutRendererLayout branch from a65551f to 7fd50ae Compare September 4, 2019 21:13
@304NotModified 304NotModified merged commit 8094327 into NLog:master Sep 8, 2019
@304NotModified
Copy link
Member

Thanks!

@304NotModified 304NotModified added enhancement Improvement on existing feature needs documentation on wiki labels Oct 25, 2019
@304NotModified
Copy link
Member

@snakefoot Do you think we should document this somewhere?

@snakefoot
Copy link
Contributor Author

snakefoot commented Oct 25, 2019 •
edited

@304NotModified Do you think we should document this somewhere?

Well everyone think that all properties in NLog supports layoutrenderers, then I guess it is okay giving the users that illusion here. Instead of writing everywhere that it doesn't work.

@304NotModified
Copy link
Member

OK!

@snakefoot snakefoot deleted the PerformanceLayoutRendererLayout branch April 4, 2020 12:53
@snakefoot snakefoot mentioned this pull request Jan 17, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees

@304NotModified 304NotModified

Labels
enhancement Improvement on existing feature size/L
Projects
None yet
Milestone
4.6.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snakefoot @304NotModified