Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonSerializer - Ensure invariant formatting of DateTimeOffset #4142

Merged
merged 1 commit into from Oct 30, 2020
Merged

JsonSerializer - Ensure invariant formatting of DateTimeOffset #4142

merged 1 commit into from Oct 30, 2020

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 22, 2020 •
edited

Really strange but VS2019 16.8 Preview then this:

QuoteValue(destination, $"{value:yyyy-MM-dd HH:mm:ss zzz}");`

Fails in formatting:

   Expected: "2016-12-31 02:30:59 +04:30"
    Actual:   "2016-12-31 02.30.59 +04:30"

By forcing CultureInfo.InvariantCulture then it works as expected.

@snakefoot snakefoot added bug Bug report / Bug fix json / json-layout labels Oct 22, 2020
@snakefoot snakefoot added this to the 4.7.6 milestone Oct 22, 2020
@snakefoot snakefoot changed the base branch from dev to master October 26, 2020 00:10
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@304NotModified 304NotModified merged commit 19de9e7 into NLog:master Oct 30, 2020
@304NotModified
Copy link
Member

nice!

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
@snakefoot snakefoot deleted the JsonDateTimeOffsetInvariant branch July 30, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bug report / Bug fix json / json-layout size/M
Projects
None yet
Milestone
4.7.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snakefoot @304NotModified