Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoggingConfigurationParser - Added support for using assembly-name in type-name (comma delimiter) #4308

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 15, 2021

Follow up to #4300, so instead you can do this:

<targets>
   <target name="evt" type="EventLog, NLog.WindowsEventLog" />
</targets>

Or like this:

<targets>
   <target name="elmah" type="elmah.io, Elmah.Io.NLog" />
</targets>

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit ed1fbe7 into NLog:dev Feb 17, 2021
@snakefoot
Copy link
Contributor Author

Updated wiki: https://github.com/NLog/NLog/wiki/Register-your-custom-component with using fully qualified name.

@snakefoot
Copy link
Contributor Author

Updated wiki: https://github.com/NLog/NLog/wiki/Configuration-file#extensions about using fully qualified type-name.

@snakefoot
Copy link
Contributor Author

It seems that using Elmah.Io.NLog, elmah.io in xsi:type is not valid format, when using XML-schema-validation.

It complains that , (Hexidecimal value 0x2C) is not acceptable. See also #4978

@snakefoot snakefoot deleted the ExtensionTypeLoadAssembly branch July 30, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) feature needs documentation on wiki nlog-configuration size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant