Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoggingRule.Final only suppresses matching levels. #467

Merged
1 commit merged into from Dec 29, 2014

Conversation

ilya-g
Copy link
Contributor

@ilya-g ilya-g commented Dec 12, 2014

Fix for #423

Added a test that reproduces the bug and passes after the change.

@ghost ghost added this to the 4.0 milestone Dec 29, 2014
@ghost ghost added the bug Bug report / Bug fix label Dec 29, 2014
ghost pushed a commit that referenced this pull request Dec 29, 2014
LoggingRule.Final only suppresses matching levels.
@ghost ghost merged commit 12c752f into NLog:master Dec 29, 2014
@ghost
Copy link

ghost commented Dec 29, 2014

Thanks for the pull request, it has been merged

@ilya-g ilya-g deleted the FinalRuleMatching branch December 30, 2014 02:31
@snakefoot
Copy link
Contributor

I have an application with different 3rd Party Dependencies. I have created some very specific logger-name-star-filters with final for these dependencies (Info-level and above), and then everything else (my stuff) goes to the catch-all-star-logger.

Does this change mean that I have specify these 3rd Party dependencies logger-filters for each log-level, so they don't get caught by my catch-all-star-loggger?.

Is there a setting so I can specify "FinalAll" and not just "FinalLevel" for my 3rd Party Dependency logger-filters?

@304NotModified
Copy link
Member

Hi @snakefoot , please open a new issue for this (reference to the PR would be nice) and please post an example config.

@snakefoot
Copy link
Contributor

Will minLevel + Final for the 3rd Party Dependency loggers (Instead of just Level), make sure that nothing unwanted reaches my catch-all-start-logger?

@NLog NLog locked and limited conversation to collaborators Jun 9, 2015
@NLog NLog unlocked this conversation Jun 12, 2015
@304NotModified
Copy link
Member

@snakefoot yes, you can use minlevel or just remove the whole level attributes.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants