Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve InternalLogger output for named wrapper targets #4784

Merged
merged 1 commit into from Jan 29, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jan 29, 2022

Followup to #4431. When Wrapper-Target has Name, then it should not say [unnamed]

Instead of writing this:

2021-05-15 20:54:26.7775 Debug logNamePattern: (:All) levels: [ Error Fatal ] writeTo: [ AsyncWrapper([unnamed])_FileTarget(Name=file) ]

Then it will write this:

2021-05-15 20:54:26.7775 Debug logNamePattern: (:All) levels: [ Error Fatal ] writeTo: [ AsyncWrapper_FileTarget(Name=file) ]

@snakefoot snakefoot added enhancement Improvement on existing feature refactoring labels Jan 29, 2022
@snakefoot snakefoot added this to the 5.0 (new) milestone Jan 29, 2022
@snakefoot snakefoot enabled auto-merge (squash) January 29, 2022 14:20
@snakefoot snakefoot closed this Jan 29, 2022
auto-merge was automatically disabled January 29, 2022 14:45

Pull request was closed

@snakefoot snakefoot reopened this Jan 29, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot enabled auto-merge (squash) January 29, 2022 15:13
@snakefoot snakefoot merged commit df2b230 into NLog:dev Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant