Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoFlushTargetWrapper - Fix race-condition that makes unit-tests unstable #5076

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Sep 27, 2022

Flush-registration (that are also seen as pending operations) should correctly notify/release other flush-registrations running concurrently.

Flush-registrations are only released when all original pending operations have completed. Bug introduced with #1868

@snakefoot snakefoot added bug Bug report / Bug fix unit-tests labels Sep 27, 2022
@snakefoot snakefoot force-pushed the asyncflush-bugfix branch 3 times, most recently from cb8a853 to 63477e7 Compare September 27, 2022 21:58
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit 08adfec into NLog:dev Sep 29, 2022
@snakefoot snakefoot added this to the 5.0.5 milestone Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix size/L unit-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant