ScopeContext - Replace recursive lookup with enumeration #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
scopecontext-recursion
branch
11 times, most recently
from
ac0e155
to
7dd61c2
Compare
snakefoot
force-pushed
the
scopecontext-recursion
branch
from
7dd61c2
to
d892162
Compare
|
Kudos, SonarCloud Quality Gate passed! |
snakefoot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #5171
ScopeContext is optimized to have minimal overhead, until making actual property-lookup. To also make the property-lookup very fast, where it used recursion to build the lookup-dictionary with minimal allocation (resolve exact initial-capacity). But recursion can lead to stackoverflow, so better to be a little slower than to be dead.