Refactor - Apply ThrowIfNull and ThrowIfNullOrEmpty

[nih0n]

Resolves #5055

Changes

Added Guard class with two methods

static T ThrowIfNull<T>(T arg, [CallerArgumentExpression("arg")] string param = "")
static string ThrowIfNullOrEmpty(string arg, [CallerArgumentExpression("arg")] string param = "")

and replaced all occurrences of

if (arg is null)
    throw new ArgumentNullException(nameof(arg));

// and

if (string.IsNullOrEmpty(arg))
    throw new ArgumentNullException(nameof(arg));

Remarks

This is the only line that we use the message parameter of ArgumentNullException so I didn't wanted to include it in the Guard methods

NLog/src/NLog/LogFactory.cs

Line 1074 in 589ee8b

throw new ArgumentNullException(nameof(name), "Name of logger cannot be null");

This check is in a different assembly so I didn't added the refence to the Guard. I don't know if it would be ok.

NLog/tests/PackageLoaderTestAssembly/NLogPackageLoaders.cs

Line 74 in 589ee8b

throw new ArgumentNullException(nameof(fact));

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

93.6% Coverage
0.0% Duplication

[snakefoot]

Thank you so much, and again sorry about the trouble.

It seems like the obsolete-adventure for NLog v5.2 is almost done. Just need to make a T4-template to replace NLog-Assembly-Scanning. Then everything can be merged.

[snakefoot]

Finally able to start preparing the NLog v5.2 release with support for NET Trimming.

Thank you again for this nice codef-refactoring.