Remove irrelevant StructuredMessageTemplateAttribute #5266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! |
|
Kudos, SonarCloud Quality Gate passed!
|
snakefoot
approved these changes
Jun 26, 2023
|
Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks! |
|
NLog v5.2.1 has now been released - https://www.nuget.org/packages/NLog Thank you again for taking the time to report and fix this issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that some overloads in
ILoggerhave the[StructuredMessageTemplate]but they don't actually treat the input as a structured message, instead treating it like a regular string. This leads to false-positives in R# and irrelevant syntax highlighting. I believe these attributes shouldn't be here, as they are only applied to theDebuglevel (search link) (andFatalfor obsolete version of the method). Note that these methods also don't have[MessageTemplateFormatMethod].