Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoFlushTargetWrapper - Explicit flush should also await when FlushOnConditionOnly #5308

Merged
merged 1 commit into from Aug 5, 2023
Merged

AutoFlushTargetWrapper - Explicit flush should also await when FlushOnConditionOnly #5308

merged 1 commit into from Aug 5, 2023

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Aug 5, 2023 •
edited

Trying to resolve #5305

NLog.LogManager.Flush(); // will now await already pending async-flush-operations when FlushOnConditionOnly = true

@snakefoot snakefoot added the enhancement Improvement on existing feature label Aug 5, 2023
@snakefoot snakefoot added this to the 5.2.3 milestone Aug 5, 2023
@snakefoot snakefoot mentioned this pull request Aug 5, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@snakefoot snakefoot merged commit 6eab802 into NLog:dev Aug 5, 2023
5 checks passed
@snakefoot snakefoot changed the title AutoFlushTargetWrapper - Explicit flush should await when FlushOnConditionOnly AutoFlushTargetWrapper - Explicit flush should also await when FlushOnConditionOnly Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature size/M
Projects
None yet
Milestone
5.2.3
Development

Successfully merging this pull request may close these issues.

Network target not working with AutoFlushWrapper and BufferingWrapper
1 participant
@snakefoot